-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Confirmation Modal - show warning message when nothing has been changed in modal. (#199523) #199858
Merged
kibanamachine
merged 1 commit into
elastic:8.x
from
kibanamachine:backport/8.x/pr-199523
Nov 12, 2024
Merged
[8.x] Confirmation Modal - show warning message when nothing has been changed in modal. (#199523) #199858
kibanamachine
merged 1 commit into
elastic:8.x
from
kibanamachine:backport/8.x/pr-199523
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in modal. (elastic#199523) (cherry picked from commit 5d0b62c)
2 tasks
💚 Build Succeeded
Metrics [docs]Async chunks
cc @CAWilson94 |
CAWilson94
added a commit
that referenced
this pull request
Nov 19, 2024
…n changed in modal. (#199523) (#200691) # Backport This will backport the following commits from `main` to `8.16`: - [Confirmation Modal - show warning message when nothing has been changed in modal. (#199523)](#199523) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Charlotte Alexandra Wilson","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T18:21:50Z","message":"Confirmation Modal - show warning message when nothing has been changed in modal. (#199523)","sha":"5d0b62ce9eb19a23cc8abfd6506be3f0f687ee80","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Theme: entity_analytics","Feature:Entity Analytics","Team:Entity Analytics","v8.16.0","backport:version","v8.17.0"],"number":199523,"url":"https://github.com/elastic/kibana/pull/199523","mergeCommit":{"message":"Confirmation Modal - show warning message when nothing has been changed in modal. (#199523)","sha":"5d0b62ce9eb19a23cc8abfd6506be3f0f687ee80"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199523","number":199523,"mergeCommit":{"message":"Confirmation Modal - show warning message when nothing has been changed in modal. (#199523)","sha":"5d0b62ce9eb19a23cc8abfd6506be3f0f687ee80"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/199858","number":199858,"state":"MERGED","mergeCommit":{"sha":"079c2269714073af316e501ec5fb2d8442e76620","message":"[8.x] Confirmation Modal - show warning message when nothing has been changed in modal. (#199523) (#199858)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [Confirmation Modal - show warning message when nothing has been\nchanged in modal.\n(#199523)](https://github.com/elastic/kibana/pull/199523)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Charlotte Alexandra\nWilson\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-12T18:21:50Z\",\"message\":\"Confirmation\nModal - show warning message when nothing has been changed in modal.\n(#199523)\",\"sha\":\"5d0b62ce9eb19a23cc8abfd6506be3f0f687ee80\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:\nSecuritySolution\",\"Theme: entity_analytics\",\"Feature:Entity\nAnalytics\",\"Team:Entity\nAnalytics\",\"v8.16.0\",\"backport:version\",\"v8.17.0\"],\"title\":\"Confirmation\nModal - show warning message when nothing has been changed in modal.\n\",\"number\":199523,\"url\":\"https://github.com/elastic/kibana/pull/199523\",\"mergeCommit\":{\"message\":\"Confirmation\nModal - show warning message when nothing has been changed in modal.\n(#199523)\",\"sha\":\"5d0b62ce9eb19a23cc8abfd6506be3f0f687ee80\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\",\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/199523\",\"number\":199523,\"mergeCommit\":{\"message\":\"Confirmation\nModal - show warning message when nothing has been changed in modal.\n(#199523)\",\"sha\":\"5d0b62ce9eb19a23cc8abfd6506be3f0f687ee80\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.x\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v8.17.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Charlotte Alexandra Wilson <[email protected]>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to8.x
:Questions ?
Please refer to the Backport tool documentation