Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [UA][Core] Surface integrations with internal APIs in upgrade assistant (#199026) #199764

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Nov 12, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@Bamieh
Copy link
Member Author

Bamieh commented Nov 12, 2024

@elasticmachine merge upstream

@Bamieh
Copy link
Member Author

Bamieh commented Nov 12, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-deprecations-common 9 12 +3
@kbn/core-http-server 232 242 +10
@kbn/core-usage-data-server 154 156 +2
total +15

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/core-deprecations-common 1 0 -1
@kbn/core-http-server 1 0 -1
total -2
Unknown metric groups

API count

id before after diff
@kbn/core-deprecations-common 17 20 +3
@kbn/core-http-server 552 568 +16
@kbn/core-usage-data-server 165 167 +2
total +21

History

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh Bamieh merged commit cf6110a into elastic:8.x Nov 12, 2024
21 checks passed
@Bamieh Bamieh deleted the backport/8.x/pr-199026 branch November 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants