[ML] Functional tests - cleanMlIndices without system index access #199653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
botelastic
bot
added
the
ci:project-deploy-observability
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
approved these changes
Nov 19, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @pheyos |
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/11976769607 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
…lastic#199653) ## Summary This PR updates the `cleanMlIndices` service method to no longer run with `esDeleteAllIndices` and thus no longer requires system index superuser privileges. ### Details / other changes - Not all ML items can be cleaned up through APIs (e.g. notifications), so tests have been adjusted to deal with pre-existing data - Some cleanup steps had to be re-ordered - Basic license tests didn't need the `cleanMlIndices` in their `before` so it was removed there - Observability serverless tests can't use `cleanMlIndices` as the APIs for DFA are not available for that project type, so the cleanup is changed to `cleanAnomalyDetection` for the AD tests and the `cleanMlIndices` is removed from the AI assistant helpers as the existing cleanup there should be enough (cherry picked from commit 93dac54)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
…lastic#199653) ## Summary This PR updates the `cleanMlIndices` service method to no longer run with `esDeleteAllIndices` and thus no longer requires system index superuser privileges. ### Details / other changes - Not all ML items can be cleaned up through APIs (e.g. notifications), so tests have been adjusted to deal with pre-existing data - Some cleanup steps had to be re-ordered - Basic license tests didn't need the `cleanMlIndices` in their `before` so it was removed there - Observability serverless tests can't use `cleanMlIndices` as the APIs for DFA are not available for that project type, so the cleanup is changed to `cleanAnomalyDetection` for the AD tests and the `cleanMlIndices` is removed from the AI assistant helpers as the existing cleanup there should be enough (cherry picked from commit 93dac54)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
…cess (#199653) (#201434) # Backport This will backport the following commits from `main` to `8.17`: - [[ML] Functional tests - cleanMlIndices without system index access (#199653)](#199653) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Oskamp","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T16:54:01Z","message":"[ML] Functional tests - cleanMlIndices without system index access (#199653)\n\n## Summary\r\n\r\nThis PR updates the `cleanMlIndices` service method to no longer run\r\nwith `esDeleteAllIndices` and thus no longer requires system index\r\nsuperuser privileges.\r\n\r\n### Details / other changes\r\n\r\n- Not all ML items can be cleaned up through APIs (e.g. notifications),\r\nso tests have been adjusted to deal with pre-existing data\r\n- Some cleanup steps had to be re-ordered\r\n- Basic license tests didn't need the `cleanMlIndices` in their `before`\r\nso it was removed there\r\n- Observability serverless tests can't use `cleanMlIndices` as the APIs\r\nfor DFA are not available for that project type, so the cleanup is\r\nchanged to `cleanAnomalyDetection` for the AD tests and the\r\n`cleanMlIndices` is removed from the AI assistant helpers as the\r\nexisting cleanup there should be enough","sha":"93dac5435ff51a3b28c5b3dd30bc4c24d1cf302c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability","v8.17.0"],"title":"[ML] Functional tests - cleanMlIndices without system index access","number":199653,"url":"https://github.com/elastic/kibana/pull/199653","mergeCommit":{"message":"[ML] Functional tests - cleanMlIndices without system index access (#199653)\n\n## Summary\r\n\r\nThis PR updates the `cleanMlIndices` service method to no longer run\r\nwith `esDeleteAllIndices` and thus no longer requires system index\r\nsuperuser privileges.\r\n\r\n### Details / other changes\r\n\r\n- Not all ML items can be cleaned up through APIs (e.g. notifications),\r\nso tests have been adjusted to deal with pre-existing data\r\n- Some cleanup steps had to be re-ordered\r\n- Basic license tests didn't need the `cleanMlIndices` in their `before`\r\nso it was removed there\r\n- Observability serverless tests can't use `cleanMlIndices` as the APIs\r\nfor DFA are not available for that project type, so the cleanup is\r\nchanged to `cleanAnomalyDetection` for the AD tests and the\r\n`cleanMlIndices` is removed from the AI assistant helpers as the\r\nexisting cleanup there should be enough","sha":"93dac5435ff51a3b28c5b3dd30bc4c24d1cf302c"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199653","number":199653,"mergeCommit":{"message":"[ML] Functional tests - cleanMlIndices without system index access (#199653)\n\n## Summary\r\n\r\nThis PR updates the `cleanMlIndices` service method to no longer run\r\nwith `esDeleteAllIndices` and thus no longer requires system index\r\nsuperuser privileges.\r\n\r\n### Details / other changes\r\n\r\n- Not all ML items can be cleaned up through APIs (e.g. notifications),\r\nso tests have been adjusted to deal with pre-existing data\r\n- Some cleanup steps had to be re-ordered\r\n- Basic license tests didn't need the `cleanMlIndices` in their `before`\r\nso it was removed there\r\n- Observability serverless tests can't use `cleanMlIndices` as the APIs\r\nfor DFA are not available for that project type, so the cleanup is\r\nchanged to `cleanAnomalyDetection` for the AD tests and the\r\n`cleanMlIndices` is removed from the AI assistant helpers as the\r\nexisting cleanup there should be enough","sha":"93dac5435ff51a3b28c5b3dd30bc4c24d1cf302c"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Oskamp <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
…ess (#199653) (#201435) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Functional tests - cleanMlIndices without system index access (#199653)](#199653) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Oskamp","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T16:54:01Z","message":"[ML] Functional tests - cleanMlIndices without system index access (#199653)\n\n## Summary\r\n\r\nThis PR updates the `cleanMlIndices` service method to no longer run\r\nwith `esDeleteAllIndices` and thus no longer requires system index\r\nsuperuser privileges.\r\n\r\n### Details / other changes\r\n\r\n- Not all ML items can be cleaned up through APIs (e.g. notifications),\r\nso tests have been adjusted to deal with pre-existing data\r\n- Some cleanup steps had to be re-ordered\r\n- Basic license tests didn't need the `cleanMlIndices` in their `before`\r\nso it was removed there\r\n- Observability serverless tests can't use `cleanMlIndices` as the APIs\r\nfor DFA are not available for that project type, so the cleanup is\r\nchanged to `cleanAnomalyDetection` for the AD tests and the\r\n`cleanMlIndices` is removed from the AI assistant helpers as the\r\nexisting cleanup there should be enough","sha":"93dac5435ff51a3b28c5b3dd30bc4c24d1cf302c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability","v8.17.0"],"title":"[ML] Functional tests - cleanMlIndices without system index access","number":199653,"url":"https://github.com/elastic/kibana/pull/199653","mergeCommit":{"message":"[ML] Functional tests - cleanMlIndices without system index access (#199653)\n\n## Summary\r\n\r\nThis PR updates the `cleanMlIndices` service method to no longer run\r\nwith `esDeleteAllIndices` and thus no longer requires system index\r\nsuperuser privileges.\r\n\r\n### Details / other changes\r\n\r\n- Not all ML items can be cleaned up through APIs (e.g. notifications),\r\nso tests have been adjusted to deal with pre-existing data\r\n- Some cleanup steps had to be re-ordered\r\n- Basic license tests didn't need the `cleanMlIndices` in their `before`\r\nso it was removed there\r\n- Observability serverless tests can't use `cleanMlIndices` as the APIs\r\nfor DFA are not available for that project type, so the cleanup is\r\nchanged to `cleanAnomalyDetection` for the AD tests and the\r\n`cleanMlIndices` is removed from the AI assistant helpers as the\r\nexisting cleanup there should be enough","sha":"93dac5435ff51a3b28c5b3dd30bc4c24d1cf302c"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199653","number":199653,"mergeCommit":{"message":"[ML] Functional tests - cleanMlIndices without system index access (#199653)\n\n## Summary\r\n\r\nThis PR updates the `cleanMlIndices` service method to no longer run\r\nwith `esDeleteAllIndices` and thus no longer requires system index\r\nsuperuser privileges.\r\n\r\n### Details / other changes\r\n\r\n- Not all ML items can be cleaned up through APIs (e.g. notifications),\r\nso tests have been adjusted to deal with pre-existing data\r\n- Some cleanup steps had to be re-ordered\r\n- Basic license tests didn't need the `cleanMlIndices` in their `before`\r\nso it was removed there\r\n- Observability serverless tests can't use `cleanMlIndices` as the APIs\r\nfor DFA are not available for that project type, so the cleanup is\r\nchanged to `cleanAnomalyDetection` for the AD tests and the\r\n`cleanMlIndices` is removed from the AI assistant helpers as the\r\nexisting cleanup there should be enough","sha":"93dac5435ff51a3b28c5b3dd30bc4c24d1cf302c"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Oskamp <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…lastic#199653) ## Summary This PR updates the `cleanMlIndices` service method to no longer run with `esDeleteAllIndices` and thus no longer requires system index superuser privileges. ### Details / other changes - Not all ML items can be cleaned up through APIs (e.g. notifications), so tests have been adjusted to deal with pre-existing data - Some cleanup steps had to be re-ordered - Basic license tests didn't need the `cleanMlIndices` in their `before` so it was removed there - Observability serverless tests can't use `cleanMlIndices` as the APIs for DFA are not available for that project type, so the cleanup is changed to `cleanAnomalyDetection` for the AD tests and the `cleanMlIndices` is removed from the AI assistant helpers as the existing cleanup there should be enough
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…lastic#199653) ## Summary This PR updates the `cleanMlIndices` service method to no longer run with `esDeleteAllIndices` and thus no longer requires system index superuser privileges. ### Details / other changes - Not all ML items can be cleaned up through APIs (e.g. notifications), so tests have been adjusted to deal with pre-existing data - Some cleanup steps had to be re-ordered - Basic license tests didn't need the `cleanMlIndices` in their `before` so it was removed there - Observability serverless tests can't use `cleanMlIndices` as the APIs for DFA are not available for that project type, so the cleanup is changed to `cleanAnomalyDetection` for the AD tests and the `cleanMlIndices` is removed from the AI assistant helpers as the existing cleanup there should be enough
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
cleanMlIndicesservice method to no longer run withesDeleteAllIndicesand thus no longer requires system index superuser privileges.Details / other changes
cleanMlIndicesin theirbeforeso it was removed therecleanMlIndicesas the APIs for DFA are not available for that project type, so the cleanup is changed tocleanAnomalyDetectionfor the AD tests and thecleanMlIndicesis removed from the AI assistant helpers as the existing cleanup there should be enough