-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Fix overview page vizs for large number of monitors !! #199512
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
50e64b6
handle overview page
shahzad31 d24afc3
fix stats panels
shahzad31 a3819da
Merge branch 'main' into fix-vizs
shahzad31 451817a
Merge branch 'main' of https://github.com/elastic/kibana into fix-vizs
shahzad31 cb3e513
fix ref warnings
shahzad31 146d1e6
Merge branch 'main' of https://github.com/elastic/kibana into fix-vizs
shahzad31 c9b61b5
fix query filters
shahzad31 ede58e5
work around for schedule
shahzad31 2626be8
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine 9289fa4
Merge branch 'main' into fix-vizs
shahzad31 50043c7
Merge branch 'main' of https://github.com/elastic/kibana into fix-vizs
shahzad31 977957f
Added tests
shahzad31 40631f4
update decimals
shahzad31 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
...n/synthetics/public/apps/synthetics/components/monitors_page/hooks/use_monitor_filters.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { UrlFilter } from '@kbn/exploratory-view-plugin/public'; | ||
import { useSelector } from 'react-redux'; | ||
import { useGetUrlParams } from '../../../hooks'; | ||
import { useKibanaSpace } from '../../../../../hooks/use_kibana_space'; | ||
import { selectOverviewStatus } from '../../../state/overview_status'; | ||
|
||
export const useMonitorFilters = ({ forAlerts }: { forAlerts?: boolean }): UrlFilter[] => { | ||
const { space } = useKibanaSpace(); | ||
const { locations, monitorTypes, tags, projects, schedules } = useGetUrlParams(); | ||
const { status: overviewStatus } = useSelector(selectOverviewStatus); | ||
const allIds = overviewStatus?.allIds ?? []; | ||
|
||
return [ | ||
// since schedule isn't available in heartbeat data, in that case we rely on monitor.id | ||
...(allIds?.length && schedules ? [{ field: 'monitor.id', values: allIds }] : []), | ||
...(projects?.length ? [{ field: 'monitor.project.id', values: getValues(projects) }] : []), | ||
...(monitorTypes?.length ? [{ field: 'monitor.type', values: getValues(monitorTypes) }] : []), | ||
...(tags?.length ? [{ field: 'tags', values: getValues(tags) }] : []), | ||
...(locations?.length ? [{ field: 'observer.geo.name', values: getValues(locations) }] : []), | ||
...(space | ||
? [{ field: forAlerts ? 'kibana.space_ids' : 'meta.space_id', values: [space.id] }] | ||
: []), | ||
]; | ||
}; | ||
|
||
const getValues = (values: string | string[]): string[] => { | ||
return Array.isArray(values) ? values : [values]; | ||
}; |
18 changes: 18 additions & 0 deletions
18
...hetics/public/apps/synthetics/components/monitors_page/hooks/use_monitor_query_filters.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { useMemo } from 'react'; | ||
import { useGetUrlParams } from '../../../hooks'; | ||
import { getQueryFilters } from '../../../../../../common/constants/client_defaults'; | ||
|
||
export const useMonitorQueryFilters = () => { | ||
const { query } = useGetUrlParams(); | ||
|
||
return useMemo(() => { | ||
return query ? [getQueryFilters(query)] : undefined; | ||
}, [query]); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of code branching in here, ideally we'd have some unit tests to make sure we avoid inadvertent modifications to the hook's output.