Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove functionbeat tutorial and translations #199301

Merged
merged 15 commits into from
Nov 13, 2024

Conversation

AndersonQ
Copy link
Member

@AndersonQ AndersonQ commented Nov 7, 2024

Summary

Remove references to functionbeat. It's been deprecated and won't be shipped on 9.0

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

I'm not sure, its just deleting code/documentation

For maintainers

Related issues

@AndersonQ AndersonQ added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 auto-backport-next backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Nov 7, 2024
@AndersonQ AndersonQ self-assigned this Nov 7, 2024
@AndersonQ AndersonQ requested review from a team as code owners November 7, 2024 12:11
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

@AndersonQ AndersonQ mentioned this pull request Nov 7, 2024
8 tasks
@AndersonQ AndersonQ force-pushed the 40745-beats-remove-functionbeat-pt2 branch from e34c137 to 92b320c Compare November 7, 2024 16:17
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

@@ -30,8 +30,6 @@ const LOGS_INDEX_PATTERN_NAMES: ObsPatternName[] = [
'metricbeat',
'generic-metricbeat',
'apm',
'functionbeat',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we certain that we don't want to track the presence of functionbeat indices in Kibana 9.0.0? Can there be a scenario that there are legacy/remnant functionbeat indices/data streams that we want to track?

…pt2' into 40745-beats-remove-functionbeat-pt2
@AndersonQ AndersonQ requested a review from awahab07 November 13, 2024 09:57
@AndersonQ
Copy link
Member Author

@awahab07 I made the change you suggested, could you re-review it please?

@AndersonQ AndersonQ changed the title Remove references to functionbeat Remove functionbeat tutorial and translations Nov 13, 2024
@AndersonQ
Copy link
Member Author

I tried to make it just about the tutorials and then I'll followup with another PR to deal with the "legacy/remnant functionbeat indices/data streams".

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 6431814
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199301-643181403ea0

Metrics [docs]

✅ unchanged

History

cc @AndersonQ

@AndersonQ AndersonQ merged commit 710c4cc into elastic:main Nov 13, 2024
24 checks passed
@AndersonQ AndersonQ deleted the 40745-beats-remove-functionbeat-pt2 branch November 13, 2024 13:34
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11818374429

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.16 Backport failed because of merge conflicts
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 199301

Questions ?

Please refer to the Backport tool documentation

AndersonQ added a commit to AndersonQ/kibana that referenced this pull request Nov 13, 2024
## Summary

Remove functionbeat tutorial and translations. It's been deprecated and won't be
shipped on 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

I'm not sure, its just deleting code/documentation

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Related issues

- Relates elastic/beats#40745
- elastic#193030

(cherry picked from commit 710c4cc)

# Conflicts:
#	api_docs/telemetry.devdocs.json
#	x-pack/plugins/translations/translations/zh-CN.json
AndersonQ added a commit to AndersonQ/kibana that referenced this pull request Nov 13, 2024
## Summary

Remove functionbeat tutorial and translations. It's been deprecated and won't be
shipped on 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

I'm not sure, its just deleting code/documentation

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Related issues

- Relates elastic/beats#40745
- elastic#193030

(cherry picked from commit 710c4cc)

# Conflicts:
#	api_docs/telemetry.devdocs.json
#	x-pack/plugins/translations/translations/zh-CN.json
@AndersonQ
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

AndersonQ added a commit that referenced this pull request Nov 13, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [Remove functionbeat tutorial and translations
(#199301)](#199301)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anderson
Queiroz","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T13:33:56Z","message":"Remove
functionbeat tutorial and translations (#199301)\n\n##
Summary\r\n\r\nRemove functionbeat tutorial and translations. It's been
deprecated and won't be\r\nshipped on 9.0\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n### Risk Matrix\r\n\r\nI'm not sure, its just deleting
code/documentation\r\n\r\n### For maintainers\r\n\r\n- [ ] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n##
Related issues\r\n\r\n- Relates
https://github.com/elastic/beats/issues/40745\r\n-
https://github.com/elastic/kibana/issues/193030","sha":"710c4cc9b147260f027e5103167599f7a0fcfdec","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","auto-backport-next","backport:prev-minor","ci:project-deploy-observability","v8.16.0","backport:version","v8.17.0"],"number":199301,"url":"https://github.com/elastic/kibana/pull/199301","mergeCommit":{"message":"Remove
functionbeat tutorial and translations (#199301)\n\n##
Summary\r\n\r\nRemove functionbeat tutorial and translations. It's been
deprecated and won't be\r\nshipped on 9.0\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n### Risk Matrix\r\n\r\nI'm not sure, its just deleting
code/documentation\r\n\r\n### For maintainers\r\n\r\n- [ ] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n##
Related issues\r\n\r\n- Relates
https://github.com/elastic/beats/issues/40745\r\n-
https://github.com/elastic/kibana/issues/193030","sha":"710c4cc9b147260f027e5103167599f7a0fcfdec"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199301","number":199301,"mergeCommit":{"message":"Remove
functionbeat tutorial and translations (#199301)\n\n##
Summary\r\n\r\nRemove functionbeat tutorial and translations. It's been
deprecated and won't be\r\nshipped on 9.0\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n### Risk Matrix\r\n\r\nI'm not sure, its just deleting
code/documentation\r\n\r\n### For maintainers\r\n\r\n- [ ] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n##
Related issues\r\n\r\n- Relates
https://github.com/elastic/beats/issues/40745\r\n-
https://github.com/elastic/kibana/issues/193030","sha":"710c4cc9b147260f027e5103167599f7a0fcfdec"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Carlos Crespo <[email protected]>
AndersonQ added a commit that referenced this pull request Nov 13, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Remove functionbeat tutorial and translations
(#199301)](#199301)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anderson
Queiroz","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T13:33:56Z","message":"Remove
functionbeat tutorial and translations (#199301)\n\n##
Summary\r\n\r\nRemove functionbeat tutorial and translations. It's been
deprecated and won't be\r\nshipped on 9.0\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n### Risk Matrix\r\n\r\nI'm not sure, its just deleting
code/documentation\r\n\r\n### For maintainers\r\n\r\n- [ ] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n##
Related issues\r\n\r\n- Relates
https://github.com/elastic/beats/issues/40745\r\n-
https://github.com/elastic/kibana/issues/193030","sha":"710c4cc9b147260f027e5103167599f7a0fcfdec","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","auto-backport-next","backport:prev-minor","ci:project-deploy-observability","v8.16.0","backport:version","v8.17.0"],"number":199301,"url":"https://github.com/elastic/kibana/pull/199301","mergeCommit":{"message":"Remove
functionbeat tutorial and translations (#199301)\n\n##
Summary\r\n\r\nRemove functionbeat tutorial and translations. It's been
deprecated and won't be\r\nshipped on 9.0\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n### Risk Matrix\r\n\r\nI'm not sure, its just deleting
code/documentation\r\n\r\n### For maintainers\r\n\r\n- [ ] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n##
Related issues\r\n\r\n- Relates
https://github.com/elastic/beats/issues/40745\r\n-
https://github.com/elastic/kibana/issues/193030","sha":"710c4cc9b147260f027e5103167599f7a0fcfdec"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199301","number":199301,"mergeCommit":{"message":"Remove
functionbeat tutorial and translations (#199301)\n\n##
Summary\r\n\r\nRemove functionbeat tutorial and translations. It's been
deprecated and won't be\r\nshipped on 9.0\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n### Risk Matrix\r\n\r\nI'm not sure, its just deleting
code/documentation\r\n\r\n### For maintainers\r\n\r\n- [ ] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n##
Related issues\r\n\r\n- Relates
https://github.com/elastic/beats/issues/40745\r\n-
https://github.com/elastic/kibana/issues/193030","sha":"710c4cc9b147260f027e5103167599f7a0fcfdec"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
## Summary

Remove functionbeat tutorial and translations. It's been deprecated and won't be
shipped on 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

I'm not sure, its just deleting code/documentation

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Related issues

- Relates elastic/beats#40745
- elastic#193030
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
## Summary

Remove functionbeat tutorial and translations. It's been deprecated and won't be
shipped on 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

I'm not sure, its just deleting code/documentation

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Related issues

- Relates elastic/beats#40745
- elastic#193030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-next backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v8.16.1 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants