-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Migrate /data_view
to deployment agnostic test
#199296
Conversation
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Show resolved
Hide resolved
/data_view
to deployment agnostic test
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just few nits
# Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7371[✅] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts: 25/25 tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments, I have few more small nits and we are good to go
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a tiny nit :)
Great job!
x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/data_view/static.spec.ts
Outdated
Show resolved
Hide resolved
Serverless: ran in MKI and it was successful |
# Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
# Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
# Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @rmyz |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11795602867 |
## Summary Closes elastic#198965 Part of elastic#193245 This PR contains the changes to migrate `data_view` test folder to Deployment-agnostic testing strategy. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` ## Checks - [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] local run for serverless - [x] local run for stateful - [x] MKI run for serverless (cherry picked from commit 803738f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
#199296) (#199753) # Backport This will backport the following commits from `main` to `8.x`: - [[APM] Migrate `/data_view` to deployment agnostic test (#199296)](#199296) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T10:41:34Z","message":"[APM] Migrate `/data_view` to deployment agnostic test (#199296)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/198965\nPart of https://github.com/elastic/kibana/issues/193245\n\nThis PR contains the changes to migrate `data_view` test folder to\nDeployment-agnostic testing strategy.\n\n### How to test\n\n- Serverless\n\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=\"APM\"\n```\n\nIt's recommended to be run against\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\n\n- Stateful\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=\"APM\"\n```\n\n## Checks\n\n- [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite\n- [x] local run for serverless\n- [x] local run for stateful\n- [x] MKI run for serverless","sha":"803738fa0c8fea3cdfc4760c7b3dd667637de724","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM] Migrate `/data_view` to deployment agnostic test","number":199296,"url":"https://github.com/elastic/kibana/pull/199296","mergeCommit":{"message":"[APM] Migrate `/data_view` to deployment agnostic test (#199296)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/198965\nPart of https://github.com/elastic/kibana/issues/193245\n\nThis PR contains the changes to migrate `data_view` test folder to\nDeployment-agnostic testing strategy.\n\n### How to test\n\n- Serverless\n\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=\"APM\"\n```\n\nIt's recommended to be run against\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\n\n- Stateful\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=\"APM\"\n```\n\n## Checks\n\n- [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite\n- [x] local run for serverless\n- [x] local run for stateful\n- [x] MKI run for serverless","sha":"803738fa0c8fea3cdfc4760c7b3dd667637de724"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199296","number":199296,"mergeCommit":{"message":"[APM] Migrate `/data_view` to deployment agnostic test (#199296)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/198965\nPart of https://github.com/elastic/kibana/issues/193245\n\nThis PR contains the changes to migrate `data_view` test folder to\nDeployment-agnostic testing strategy.\n\n### How to test\n\n- Serverless\n\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=\"APM\"\n```\n\nIt's recommended to be run against\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\n\n- Stateful\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=\"APM\"\n```\n\n## Checks\n\n- [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite\n- [x] local run for serverless\n- [x] local run for stateful\n- [x] MKI run for serverless","sha":"803738fa0c8fea3cdfc4760c7b3dd667637de724"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <[email protected]>
## Summary Closes elastic#198965 Part of elastic#193245 This PR contains the changes to migrate `data_view` test folder to Deployment-agnostic testing strategy. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` ## Checks - [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] local run for serverless - [x] local run for stateful - [x] MKI run for serverless
## Summary Closes elastic#198965 Part of elastic#193245 This PR contains the changes to migrate `data_view` test folder to Deployment-agnostic testing strategy. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` ## Checks - [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] local run for serverless - [x] local run for stateful - [x] MKI run for serverless
Summary
Closes #198965
Part of #193245
This PR contains the changes to migrate
data_view
test folder to Deployment-agnostic testing strategy.How to test
It's recommended to be run against MKI
Checks