Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Migrate /data_view to deployment agnostic test #199296

Merged
merged 11 commits into from
Nov 12, 2024

Conversation

rmyz
Copy link
Contributor

@rmyz rmyz commented Nov 7, 2024

Summary

Closes #198965
Part of #193245

This PR contains the changes to migrate data_view test folder to Deployment-agnostic testing strategy.

How to test

  • Serverless
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"

It's recommended to be run against MKI

  • Stateful
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"

Checks

  • (OPTIONAL, only if a test has been unskipped) Run flaky test suite
  • local run for serverless
  • local run for stateful
  • MKI run for serverless

@rmyz rmyz changed the title test: migrate data_view to deployment agnostic tests [APM] Migrate /data_view to deployment agnostic test Nov 7, 2024
@rmyz rmyz marked this pull request as ready for review November 7, 2024 14:17
@rmyz rmyz requested review from a team as code owners November 7, 2024 14:17
@rmyz rmyz self-assigned this Nov 7, 2024
@rmyz rmyz added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

github-actions bot commented Nov 7, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just few nits

@rmyz rmyz requested a review from dmlemeshko November 9, 2024 20:43
# Conflicts:
#	x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7371

[✅] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts: 25/25 tests passed.
[✅] x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts: 25/25 tests passed.

see run history

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments, I have few more small nits and we are good to go

@rmyz rmyz requested a review from dmlemeshko November 11, 2024 10:30
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a tiny nit :)

Great job!

@rmyz
Copy link
Contributor Author

rmyz commented Nov 11, 2024

Serverless: ran in MKI and it was successful
Stateful: run in local + CI

# Conflicts:
#	x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
@rmyz rmyz enabled auto-merge (squash) November 11, 2024 15:32
@rmyz rmyz disabled auto-merge November 11, 2024 15:39
rmyz added 3 commits November 11, 2024 19:25
# Conflicts:
#	x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
# Conflicts:
#	x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 12, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 3f332ef
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199296-3f332ef74446

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack 723 722 -1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 748 747 -1

History

cc @rmyz

@rmyz rmyz merged commit 803738f into elastic:main Nov 12, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11795602867

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 12, 2024
## Summary

Closes elastic#198965
Part of elastic#193245

This PR contains the changes to migrate `data_view` test folder to
Deployment-agnostic testing strategy.

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

## Checks

- [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless

(cherry picked from commit 803738f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@rmyz rmyz deleted the 198965-apm-migrate-data_view-tests branch November 12, 2024 11:01
kibanamachine added a commit that referenced this pull request Nov 12, 2024
#199296) (#199753)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Migrate `/data_view` to deployment agnostic test
(#199296)](#199296)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T10:41:34Z","message":"[APM]
Migrate `/data_view` to deployment agnostic test (#199296)\n\n##
Summary\n\nCloses https://github.com/elastic/kibana/issues/198965\nPart
of https://github.com/elastic/kibana/issues/193245\n\nThis PR contains
the changes to migrate `data_view` test folder to\nDeployment-agnostic
testing strategy.\n\n### How to test\n\n- Serverless\n\n```\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\n```\n\nIt's recommended to be run
against\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\n\n-
Stateful\n```\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\n```\n\n## Checks\n\n- [x] (OPTIONAL, only if a test has
been unskipped) Run flaky test suite\n- [x] local run for serverless\n-
[x] local run for stateful\n- [x] MKI run for
serverless","sha":"803738fa0c8fea3cdfc4760c7b3dd667637de724","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM]
Migrate `/data_view` to deployment agnostic
test","number":199296,"url":"https://github.com/elastic/kibana/pull/199296","mergeCommit":{"message":"[APM]
Migrate `/data_view` to deployment agnostic test (#199296)\n\n##
Summary\n\nCloses https://github.com/elastic/kibana/issues/198965\nPart
of https://github.com/elastic/kibana/issues/193245\n\nThis PR contains
the changes to migrate `data_view` test folder to\nDeployment-agnostic
testing strategy.\n\n### How to test\n\n- Serverless\n\n```\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\n```\n\nIt's recommended to be run
against\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\n\n-
Stateful\n```\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\n```\n\n## Checks\n\n- [x] (OPTIONAL, only if a test has
been unskipped) Run flaky test suite\n- [x] local run for serverless\n-
[x] local run for stateful\n- [x] MKI run for
serverless","sha":"803738fa0c8fea3cdfc4760c7b3dd667637de724"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199296","number":199296,"mergeCommit":{"message":"[APM]
Migrate `/data_view` to deployment agnostic test (#199296)\n\n##
Summary\n\nCloses https://github.com/elastic/kibana/issues/198965\nPart
of https://github.com/elastic/kibana/issues/193245\n\nThis PR contains
the changes to migrate `data_view` test folder to\nDeployment-agnostic
testing strategy.\n\n### How to test\n\n- Serverless\n\n```\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\n```\n\nIt's recommended to be run
against\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\n\n-
Stateful\n```\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\n```\n\n## Checks\n\n- [x] (OPTIONAL, only if a test has
been unskipped) Run flaky test suite\n- [x] local run for serverless\n-
[x] local run for stateful\n- [x] MKI run for
serverless","sha":"803738fa0c8fea3cdfc4760c7b3dd667637de724"}}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <[email protected]>
tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Nov 12, 2024
## Summary

Closes elastic#198965
Part of elastic#193245

This PR contains the changes to migrate `data_view` test folder to
Deployment-agnostic testing strategy.

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

## Checks

- [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
## Summary

Closes elastic#198965
Part of elastic#193245

This PR contains the changes to migrate `data_view` test folder to
Deployment-agnostic testing strategy.

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

## Checks

- [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Migrate /test/apm_api_integration/tests/data_view to be deployment-agnostic API tests
7 participants