[console] adding generated spec files for xpack endpoints and adjusting code to… #19928
Conversation
… handle the same override logic
💚 Build Succeeded |
💚 Build Succeeded |
| "_xpack": { | ||
| "url_params": { | ||
| "categories": [ | ||
| "build", |
There was a problem hiding this comment.
Are these supposed to be suggested as values for this param? If so, I don't see them showing up. Let me know if this is a bug and I'll file an issue.
| "license", | ||
| "features" | ||
| ], | ||
| "human": [ |
There was a problem hiding this comment.
Is this supposed to show up as an option?
|
Good catch @cjcenizal wrong key in override file meant that the override wasn't happening. |
bmcconaghy
changed the title
💚 Build Succeeded |
💔 Build Failed |
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "xpack.ml.get_categories": { | |||
| "data_autocomplete_rules": { | |||
There was a problem hiding this comment.
FWIW, I can only get the autocompleter to suggest these for _xpack/ml/anomaly_detectors/{job_id}/results/categories/{category_id}, but not _xpack/ml/anomaly_detectors/{job_id}/results/categories
There was a problem hiding this comment.
Good catch, generated file had that path end with a slash, fixed it in overrides.
| { | ||
| "xpack.ml.get_overall_buckets": { | ||
| "data_autocomplete_rules": { | ||
| "allow_no_jobs": [true, false], |
There was a problem hiding this comment.
This and exclude_interim only populate the field with an empty array, instead of [true, false]. true and false are suggested by the autocompleter if you start typing "t" or "f" however.
There was a problem hiding this comment.
Should be fixed now, thanks for catching.
| { | ||
| "xpack.ml.get_records": { | ||
| "data_autocomplete_rules": { | ||
| "desc": "__flag__", |
There was a problem hiding this comment.
In the xpack.info endpoint, __flag__ is used within a URL parameter, and autocompleter will suggest true or false as values for the param. In this case, the autocompleter doesn't suggest these values and instead autofills the value as the string "__flag__".
There was a problem hiding this comment.
Fixed this here and elsewhere.
| "aggregations": {}, | ||
| "chunking_config": {}, | ||
| "frequency": "", | ||
| "indices": [""], |
There was a problem hiding this comment.
This array is not pre-populated with an empty string; it's inserted as an empty array.
| "PUT" | ||
| ], | ||
| "patterns": [ | ||
| "_xpack/rollup/job/{id}" |
There was a problem hiding this comment.
Any reason "methods" and "patterns" are defined both here and in the generated file?
|
@cjcenizal thanks for the thorough testing. I have addressed those things. Would you mind taking a look at this one again? |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
…ck_console_autocomplete
💚 Build Succeeded |
| ], | ||
| "patterns": [ | ||
| "_xpack/rollup/job/{id}", | ||
| "_xpack/rollup/job/" |
There was a problem hiding this comment.
Hitting this endpoint without an id returns an exception, this conflicts with the documentation so is not a console bug, but an Elasticsearch bug (rollup team has been notified and will fix).
…ng code to… (elastic#19928) * adding generated spec files for xpack endpoints and adjusting code to handle the same override logic * accounting for non URL documentation values * fixing issue with incorrect override file * adding support for unknown parameters in path (assuming they are ids) * fixing autocomplete for get_categories ml API * fixing issue with autocomplete for get_overall_buckets * fixing issue with get_overall_buckets autocomplete * fixing get_overall_buckets autocomplete issue for reals * fixing __flag__ in body autocomplete specs * fixing issue with ml put_datafeed autocomplete * removing unnecessary overrides for rollup put_job * fix issue with UrlPatternMatcher * fixing tests * fixing typos * overriding rollup get due to bug in ES specs
…ng code to… (#19928) (#20201) * adding generated spec files for xpack endpoints and adjusting code to handle the same override logic * accounting for non URL documentation values * fixing issue with incorrect override file * adding support for unknown parameters in path (assuming they are ids) * fixing autocomplete for get_categories ml API * fixing issue with autocomplete for get_overall_buckets * fixing issue with get_overall_buckets autocomplete * fixing get_overall_buckets autocomplete issue for reals * fixing __flag__ in body autocomplete specs * fixing issue with ml put_datafeed autocomplete * removing unnecessary overrides for rollup put_job * fix issue with UrlPatternMatcher * fixing tests * fixing typos * overriding rollup get due to bug in ES specs
💚 Build Succeeded |
…ng code to… (#19928) * adding generated spec files for xpack endpoints and adjusting code to handle the same override logic * accounting for non URL documentation values * fixing issue with incorrect override file * adding support for unknown parameters in path (assuming they are ids) * fixing autocomplete for get_categories ml API * fixing issue with autocomplete for get_overall_buckets * fixing issue with get_overall_buckets autocomplete * fixing get_overall_buckets autocomplete issue for reals * fixing __flag__ in body autocomplete specs * fixing issue with ml put_datafeed autocomplete * removing unnecessary overrides for rollup put_job * fix issue with UrlPatternMatcher * fixing tests * fixing typos * overriding rollup get due to bug in ES specs
… handle the same override logic
xpack spec files are now generated in the same fashion as the OSS spec files with overrides to supply body completions where applicable.