-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] New palette toggle #199243
Closed
Closed
[DNM] New palette toggle #199243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes theme:name setting and uses available theme:version instead
adds primitive color value changes
- fixes accentSecondary mapping
- adds typography scale changes
updates token mappings for borders, adds floating borders to panels with shadow
- udpates eui vis colors and palettes
-updates json tokens
updates lightestShade value
We treat palettes with any change as custom, thus when it's not custom we should apply the colors based on the vis colors. Currently they are hardcoded in the saved object. This applied to visualizations using the CustomizablePalette component: - Datatable (by value) - Gauge - Heatmap - Metric - Legacy Metric This generation must happen before the render phase since all palettes are treated as custom after converting to an expression.
- version to name of theme - light and dark palette selection - add behind text legacy palette
f2a5e6d
to
ca74ef7
Compare
Closing in favor of #201015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
theme.version
andtheme.colorMode
.paletteService
and new color mapping definitionscloses #196910
Checklist