Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] New palette toggle #199243

Closed
wants to merge 61 commits into from
Closed

Conversation

nickofthyme
Copy link
Contributor

Summary

  • Provides a mechanism to define color palettes in Lens based on theme.version and theme.colorMode.
  • Applies new default color default and gradient color palettes.
  • Provides a fallback to the old palettes
  • Works with legacy paletteService and new color mapping definitions

closes #196910

Checklist

nickofthyme and others added 30 commits October 30, 2024 10:00
- removes theme:name setting and uses available theme:version instead
adds primitive color value changes
- fixes accentSecondary mapping
- adds typography scale changes
updates token mappings for borders, adds floating borders to panels with shadow
- udpates eui vis colors and palettes
-updates json tokens
updates lightestShade value
mgadewoll and others added 12 commits November 18, 2024 12:58
We treat palettes with any change as custom, thus when it's not custom we should apply the colors based on the vis colors. Currently they are hardcoded in the saved object.

This applied to visualizations using the CustomizablePalette component:
- Datatable (by value)
- Gauge
- Heatmap
- Metric
- Legacy Metric

This generation must happen before the render phase since all palettes are treated as custom after converting to an expression.
- version to name of theme
- light and dark palette selection
- add behind text legacy palette
@nickofthyme nickofthyme added ci:project-deploy-observability Create an Observability project ci:cloud-persist-deployment Persist cloud deployment indefinitely and removed ci:project-deploy-observability Create an Observability project labels Nov 19, 2024
@elastic elastic deleted a comment from github-actions bot Nov 20, 2024
@nickofthyme nickofthyme added ci:project-deploy-observability Create an Observability project and removed ci:cloud-deploy Create or update a Cloud deployment labels Nov 20, 2024
@elastic elastic deleted a comment from github-actions bot Nov 20, 2024
@nickofthyme nickofthyme removed ci:cloud-redeploy Always create a new Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely labels Nov 20, 2024
@nickofthyme nickofthyme changed the title [DNM] New palette toggle [DNM] Borealis vis palettes Nov 20, 2024
@nickofthyme nickofthyme removed the ci:project-deploy-observability Create an Observability project label Nov 20, 2024
@nickofthyme nickofthyme changed the title [DNM] Borealis vis palettes [DNM] New palette toggle Nov 20, 2024
@nickofthyme
Copy link
Contributor Author

Closing in favor of #201015

@nickofthyme nickofthyme deleted the new-palette-toggle branch November 20, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Meta][Colors] Borealis color palette for data visualizations
4 participants