Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution] Update rule link in cases activities (#198836) #199242

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

)

## Summary

As a follow up to elastic#191764, this PR
updates rule names in `Activity` tab in cases to open a rule flyout
instead of going to rule details page.

**Security solution changes**: replace rule page navigation with a
`openFlyout` call
**Cases plugin changes**: update the rules link component to accept
either `href` or `onClick`.

![image](https://github.com/user-attachments/assets/c5dca885-61b8-4481-adfa-f9e615a01265)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 09dd66d)
@kibanamachine kibanamachine merged commit 6530bea into elastic:8.x Nov 7, 2024
37 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 492.2KB 492.2KB +39.0B
securitySolution 21.0MB 21.0MB -122.0B
total -83.0B

cc @christineweng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants