Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Dashboard] Remove modal for inter app from dashboard (#198619) #199235

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Closes elastic#184257
This PR removes the modal warning users that unsaved changes would be
lost when navigating away from dashboard to other apps within Kibana.
The modal is not necessary since unsaved changes are saved in session
storage. The benefit is that this removes the unnecessary click for
users.

This does not impact the modal for switching to view mode from edit mode
with unsaved changes as shown below.

https://github.com/user-attachments/assets/c5bdb0ec-b040-40b0-a511-fd16ad084b90

### Checklist

 - [x] Update tests

(cherry picked from commit 4f14c4a)
@kibanamachine kibanamachine merged commit 2d180fc into elastic:8.x Nov 6, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 647.4KB 646.4KB -984.0B

cc @rshen91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants