Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v97.3.1 #199186

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Upgrade EUI to v97.3.1 #199186

merged 5 commits into from
Nov 12, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Nov 6, 2024

v97.3.0v97.3.1

Questions? Please see our Kibana upgrade FAQ.


v97.3.1

Bug fixes

  • Fixed an EuiComboBox bug where Enter keypresses were not working correctly on selection clear buttons (#8105)
  • Fixed an EuiSuperDatePicker bug where inputs would overflow out of smaller widths instead of truncating (#8109)
  • Fixed a bug with EuiPageHeader's rightSideItems responsiveness where single items could overflow past the intended max width (#8110)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v9.0.0 backport:version Backport to applied version labels v8.17.0 labels Nov 6, 2024
@cee-chen cee-chen marked this pull request as ready for review November 7, 2024 16:29
@cee-chen cee-chen requested review from a team as code owners November 7, 2024 16:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen requested a review from rylnd November 7, 2024 16:29
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/kbn-test-jest-helpers changes LGTM

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

@cee-chen
Copy link
Contributor Author

@elastic/kibana-visualizations @elastic/security-detection-engine One last ping for codeowner reviews - we'll be requesting an admin merge by EOD.

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.8MB 5.8MB +380.0B

History

@jbudz jbudz merged commit 4e65ae9 into elastic:main Nov 12, 2024
44 of 45 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11788745061

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 199186

Questions ?

Please refer to the Backport tool documentation

tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Nov 12, 2024
`v97.3.0`⏩`v97.3.1`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1)

**Bug fixes**

- Fixed an `EuiComboBox` bug where Enter keypresses were not working
correctly on selection clear buttons
([elastic#8105](elastic/eui#8105))
- Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of
smaller widths instead of truncating
([elastic#8109](elastic/eui#8109))
- Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness
where single items could overflow past the intended max width
([elastic#8110](elastic/eui#8110))
@cee-chen
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@cee-chen cee-chen deleted the eui/v97.3.1 branch November 13, 2024 16:53
cee-chen added a commit to cee-chen/kibana that referenced this pull request Nov 13, 2024
`v97.3.0`⏩`v97.3.1`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1)

**Bug fixes**

- Fixed an `EuiComboBox` bug where Enter keypresses were not working
correctly on selection clear buttons
([elastic#8105](elastic/eui#8105))
- Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of
smaller widths instead of truncating
([elastic#8109](elastic/eui#8109))
- Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness
where single items could overflow past the intended max width
([elastic#8110](elastic/eui#8110))

(cherry picked from commit 4e65ae9)

# Conflicts:
#	packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap
cee-chen added a commit that referenced this pull request Nov 13, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Upgrade EUI to v97.3.1
(#199186)](#199186)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cee
Chen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T01:02:34Z","message":"Upgrade
EUI to v97.3.1 (#199186)\n\n`v97.3.0`⏩`v97.3.1`\r\n\r\n_[Questions?
Please see our Kibana
upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n##
[`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1)\r\n\r\n**Bug
fixes**\r\n\r\n- Fixed an `EuiComboBox` bug where Enter keypresses were
not working\r\ncorrectly on selection clear
buttons\r\n([#8105](https://github.com/elastic/eui/pull/8105))\r\n-
Fixed an `EuiSuperDatePicker` bug where inputs would overflow out
of\r\nsmaller widths instead of
truncating\r\n([#8109](https://github.com/elastic/eui/pull/8109))\r\n-
Fixed a bug with `EuiPageHeader`'s `rightSideItems`
responsiveness\r\nwhere single items could overflow past the intended
max
width\r\n([#8110](https://github.com/elastic/eui/pull/8110))","sha":"4e65ae9b1e69fc92341de99078bde179708b3394","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","backport:version","v8.17.0"],"number":199186,"url":"https://github.com/elastic/kibana/pull/199186","mergeCommit":{"message":"Upgrade
EUI to v97.3.1 (#199186)\n\n`v97.3.0`⏩`v97.3.1`\r\n\r\n_[Questions?
Please see our Kibana
upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n##
[`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1)\r\n\r\n**Bug
fixes**\r\n\r\n- Fixed an `EuiComboBox` bug where Enter keypresses were
not working\r\ncorrectly on selection clear
buttons\r\n([#8105](https://github.com/elastic/eui/pull/8105))\r\n-
Fixed an `EuiSuperDatePicker` bug where inputs would overflow out
of\r\nsmaller widths instead of
truncating\r\n([#8109](https://github.com/elastic/eui/pull/8109))\r\n-
Fixed a bug with `EuiPageHeader`'s `rightSideItems`
responsiveness\r\nwhere single items could overflow past the intended
max
width\r\n([#8110](https://github.com/elastic/eui/pull/8110))","sha":"4e65ae9b1e69fc92341de99078bde179708b3394"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199186","number":199186,"mergeCommit":{"message":"Upgrade
EUI to v97.3.1 (#199186)\n\n`v97.3.0`⏩`v97.3.1`\r\n\r\n_[Questions?
Please see our Kibana
upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n##
[`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1)\r\n\r\n**Bug
fixes**\r\n\r\n- Fixed an `EuiComboBox` bug where Enter keypresses were
not working\r\ncorrectly on selection clear
buttons\r\n([#8105](https://github.com/elastic/eui/pull/8105))\r\n-
Fixed an `EuiSuperDatePicker` bug where inputs would overflow out
of\r\nsmaller widths instead of
truncating\r\n([#8109](https://github.com/elastic/eui/pull/8109))\r\n-
Fixed a bug with `EuiPageHeader`'s `rightSideItems`
responsiveness\r\nwhere single items could overflow past the intended
max
width\r\n([#8110](https://github.com/elastic/eui/pull/8110))","sha":"4e65ae9b1e69fc92341de99078bde179708b3394"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
`v97.3.0`⏩`v97.3.1`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1)

**Bug fixes**

- Fixed an `EuiComboBox` bug where Enter keypresses were not working
correctly on selection clear buttons
([elastic#8105](elastic/eui#8105))
- Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of
smaller widths instead of truncating
([elastic#8109](elastic/eui#8109))
- Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness
where single items could overflow past the intended max width
([elastic#8110](elastic/eui#8110))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels EUI release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants