Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unified-data-table] clean up another SASS compilation warnings #199176

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Nov 6, 2024

Summary

Follows #198876. I found one more instance of SASS code that created compilation warnings.

@tsullivan tsullivan requested a review from a team as a code owner November 6, 2024 16:29
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 6, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@tsullivan tsullivan merged commit 437ca8b into elastic:main Nov 6, 2024
27 checks passed
@tsullivan tsullivan deleted the sass/compilation-warnings-iii branch November 6, 2024 18:22
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11709584505

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 6, 2024
…tic#199176)

## Summary

Follows elastic#198876. I found one more
instance of SASS code that created compilation warnings.

(cherry picked from commit 437ca8b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 6, 2024
…#199176) (#199212)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[unified-data-table] clean up another SASS compilation warnings
(#199176)](#199176)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tim
Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T18:22:32Z","message":"[unified-data-table]
clean up another SASS compilation warnings (#199176)\n\n##
Summary\r\n\r\nFollows #198876. I
found one more\r\ninstance of SASS code that created compilation
warnings.","sha":"437ca8bd31d896c666d15b0ccd03d1fb2f0aee9d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[unified-data-table]
clean up another SASS compilation
warnings","number":199176,"url":"https://github.com/elastic/kibana/pull/199176","mergeCommit":{"message":"[unified-data-table]
clean up another SASS compilation warnings (#199176)\n\n##
Summary\r\n\r\nFollows #198876. I
found one more\r\ninstance of SASS code that created compilation
warnings.","sha":"437ca8bd31d896c666d15b0ccd03d1fb2f0aee9d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199176","number":199176,"mergeCommit":{"message":"[unified-data-table]
clean up another SASS compilation warnings (#199176)\n\n##
Summary\r\n\r\nFollows #198876. I
found one more\r\ninstance of SASS code that created compilation
warnings.","sha":"437ca8bd31d896c666d15b0ccd03d1fb2f0aee9d"}}]}]
BACKPORT-->

Co-authored-by: Tim Sullivan <[email protected]>
mgadewoll pushed a commit to mgadewoll/kibana that referenced this pull request Nov 7, 2024
…tic#199176)

## Summary

Follows elastic#198876. I found one more
instance of SASS code that created compilation warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants