[Fleet] Added default index pattern creation to stream-based installation #199122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcrzx
force-pushed
the
fix-default-index-patterns
branch
from
e96f27b to
35860cb
Compare
PhilippeOberti
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks for opening this PR. The change fixes our Threat Hunting Investigations Cypress tests that started failing right after this PR was merged
xcrzx
force-pushed
the
fix-default-index-patterns
branch
from
35860cb to
d70af6d
Compare
...test/security_solution_cypress/cypress/e2e/investigations/sourcerer/sourcerer_timeline.cy.ts
Show resolved
Hide resolved
xcrzx
force-pushed
the
fix-default-index-patterns
branch
from
d70af6d to
f0c6f6b
Compare
xcrzx
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
xcrzx
added
release_note:skip
...test/security_solution_cypress/cypress/e2e/investigations/sourcerer/sourcerer_timeline.cy.ts
Show resolved
Hide resolved
xcrzx
force-pushed
the
fix-default-index-patterns
branch
from
f0c6f6b to
759c3d6
Compare
PhilippeOberti
approved these changes
Nov 6, 2024
💚 Build Succeeded
Metrics [docs]
History
cc @xcrzx |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11719795899 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Nov 7, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
…tion (elastic#199122) **Related to: elastic#195888 ## Summary Add default index pattern creation to the new stream-based package installation method to match the behavior of standard package installation. Switching to stream-based package installation resulted in the default index patterns not being created, even after installing the rules package. While this likely doesn’t affect production, as multiple integrations are usually installed in Kibana (creating the default index pattern in any case), this change has impacted some tests: elastic#199030. So restoring the original behaviour
xcrzx
added a commit
to xcrzx/kibana
that referenced
this pull request
Nov 8, 2024
…tion (elastic#199122) **Related to: elastic#195888 ## Summary Add default index pattern creation to the new stream-based package installation method to match the behavior of standard package installation. Switching to stream-based package installation resulted in the default index patterns not being created, even after installing the rules package. While this likely doesn’t affect production, as multiple integrations are usually installed in Kibana (creating the default index pattern in any case), this change has impacted some tests: elastic#199030. So restoring the original behaviour (cherry picked from commit 22d3e62) # Conflicts: # x-pack/test/security_solution_cypress/cypress/e2e/investigations/sourcerer/sourcerer_timeline.cy.ts
xcrzx
added a commit
that referenced
this pull request
Nov 8, 2024
…stallation (#199122) (#199453) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Added default index pattern creation to stream-based installation (#199122)](#199122) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dmitrii Shevchenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T09:04:56Z","message":"[Fleet] Added default index pattern creation to stream-based installation (#199122)\n\n**Related to: https://github.com/elastic/kibana/pull/195888**\r\n\r\n## Summary\r\n\r\nAdd default index pattern creation to the new stream-based package\r\ninstallation method to match the behavior of standard package\r\ninstallation.\r\n\r\nSwitching to stream-based package installation resulted in the default\r\nindex patterns not being created, even after installing the rules\r\npackage. While this likely doesn’t affect production, as multiple\r\nintegrations are usually installed in Kibana (creating the default index\r\npattern in any case), this change has impacted some tests:\r\nhttps://github.com//pull/199030. So restoring the original\r\nbehaviour","sha":"22d3e628931706dee4c0d8eec068575d264bb13e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:version","v8.17.0"],"number":199122,"url":"https://github.com/elastic/kibana/pull/199122","mergeCommit":{"message":"[Fleet] Added default index pattern creation to stream-based installation (#199122)\n\n**Related to: https://github.com/elastic/kibana/pull/195888**\r\n\r\n## Summary\r\n\r\nAdd default index pattern creation to the new stream-based package\r\ninstallation method to match the behavior of standard package\r\ninstallation.\r\n\r\nSwitching to stream-based package installation resulted in the default\r\nindex patterns not being created, even after installing the rules\r\npackage. While this likely doesn’t affect production, as multiple\r\nintegrations are usually installed in Kibana (creating the default index\r\npattern in any case), this change has impacted some tests:\r\nhttps://github.com//pull/199030. So restoring the original\r\nbehaviour","sha":"22d3e628931706dee4c0d8eec068575d264bb13e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199122","number":199122,"mergeCommit":{"message":"[Fleet] Added default index pattern creation to stream-based installation (#199122)\n\n**Related to: https://github.com/elastic/kibana/pull/195888**\r\n\r\n## Summary\r\n\r\nAdd default index pattern creation to the new stream-based package\r\ninstallation method to match the behavior of standard package\r\ninstallation.\r\n\r\nSwitching to stream-based package installation resulted in the default\r\nindex patterns not being created, even after installing the rules\r\npackage. While this likely doesn’t affect production, as multiple\r\nintegrations are usually installed in Kibana (creating the default index\r\npattern in any case), this change has impacted some tests:\r\nhttps://github.com//pull/199030. So restoring the original\r\nbehaviour","sha":"22d3e628931706dee4c0d8eec068575d264bb13e"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #195888
Summary
Add default index pattern creation to the new stream-based package installation method to match the behavior of standard package installation.
Switching to stream-based package installation resulted in the default index patterns not being created, even after installing the rules package. While this likely doesn’t affect production, as multiple integrations are usually installed in Kibana (creating the default index pattern in any case), this change has impacted some tests: #199030. So restoring the original behaviour