Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Disable step commit status #199073

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Nov 6, 2024

The number of steps in pull request builds has been causing GitHub API rate limit issues. In particular, scenarios that cause all steps to fail have proven to quickly trigger the rate limit.

The disables step statuses on pull requests. We will still have our required kibana-ci check for the overall build, and the pull request comment can be used as the source of individual step failures.

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting skip-ci labels Nov 6, 2024
@jbudz jbudz marked this pull request as ready for review November 6, 2024 23:35
@jbudz jbudz requested a review from a team as a code owner November 6, 2024 23:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@Ikuni17
Copy link
Contributor

Ikuni17 commented Nov 7, 2024

Should this be backported?

@jbudz
Copy link
Member Author

jbudz commented Nov 7, 2024

Should this be backported?

We're modifying the pipeline definition here, so it'll have a global effect.

@jbudz jbudz merged commit 2775089 into elastic:main Nov 27, 2024
8 checks passed
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
The number of steps in pull request builds has been causing GitHub API
rate limit issues. In particular, scenarios that cause all steps to fail
have proven to quickly trigger the rate limit.

The disables step statuses on pull requests. We will still have our
required kibana-ci check for the overall build, and the pull request
comment can be used as the source of individual step failures.
jbudz added a commit that referenced this pull request Jan 3, 2025
Previously reverted due to the number of statuses we were tracking, and
the subsequent rate limiting.

The number of updates we need to do after
#199073 is significantly lower.
We've already been using org-wide status checks for [on-merge commit
statuses](https://github.com/elastic/kibana/commits/main) in the interim
and are not seeing issues.
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
…lastic#205546)

Previously reverted due to the number of statuses we were tracking, and
the subsequent rate limiting.

The number of updates we need to do after
elastic#199073 is significantly lower.
We've already been using org-wide status checks for [on-merge commit
statuses](https://github.com/elastic/kibana/commits/main) in the interim
and are not seeing issues.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…lastic#205546)

Previously reverted due to the number of statuses we were tracking, and
the subsequent rate limiting.

The number of updates we need to do after
elastic#199073 is significantly lower.
We've already been using org-wide status checks for [on-merge commit
statuses](https://github.com/elastic/kibana/commits/main) in the interim
and are not seeing issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes skip-ci Team:Operations Team label for Operations Team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants