-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Disable step commit status #199073
Merged
Merged
[ci] Disable step commit status #199073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
Team:Operations
Team label for Operations Team
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
skip-ci
labels
Nov 6, 2024
Pinging @elastic/kibana-operations (Team:Operations) |
Ikuni17
approved these changes
Nov 7, 2024
Should this be backported? |
We're modifying the pipeline definition here, so it'll have a global effect. |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
The number of steps in pull request builds has been causing GitHub API rate limit issues. In particular, scenarios that cause all steps to fail have proven to quickly trigger the rate limit. The disables step statuses on pull requests. We will still have our required kibana-ci check for the overall build, and the pull request comment can be used as the source of individual step failures.
jbudz
added a commit
that referenced
this pull request
Jan 3, 2025
Previously reverted due to the number of statuses we were tracking, and the subsequent rate limiting. The number of updates we need to do after #199073 is significantly lower. We've already been using org-wide status checks for [on-merge commit statuses](https://github.com/elastic/kibana/commits/main) in the interim and are not seeing issues.
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
…lastic#205546) Previously reverted due to the number of statuses we were tracking, and the subsequent rate limiting. The number of updates we need to do after elastic#199073 is significantly lower. We've already been using org-wide status checks for [on-merge commit statuses](https://github.com/elastic/kibana/commits/main) in the interim and are not seeing issues.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…lastic#205546) Previously reverted due to the number of statuses we were tracking, and the subsequent rate limiting. The number of updates we need to do after elastic#199073 is significantly lower. We've already been using org-wide status checks for [on-merge commit statuses](https://github.com/elastic/kibana/commits/main) in the interim and are not seeing issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
skip-ci
Team:Operations
Team label for Operations Team
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of steps in pull request builds has been causing GitHub API rate limit issues. In particular, scenarios that cause all steps to fail have proven to quickly trigger the rate limit.
The disables step statuses on pull requests. We will still have our required kibana-ci check for the overall build, and the pull request comment can be used as the source of individual step failures.