Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Visualizer: Optimize initial load bundles. #199029

Merged
merged 4 commits into from
Nov 11, 2024
Merged

[ML] Data Visualizer: Optimize initial load bundles. #199029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db768ba
optimize page load bundles
walterra Nov 5, 2024
b469899
update bundle size limit
walterra Nov 6, 2024
f73ec59
Merge branch 'main' into ml-data-visualizer-optimize-bundles
walterra Nov 8, 2024
02ebd3d
Merge branch 'main' into ml-data-visualizer-optimize-bundles
walterra Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-optimizer/limits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pageLoadAssetSize:
dataViewFieldEditor: 42021
dataViewManagement: 5300
dataViews: 65000
dataVisualizer: 27530
dataVisualizer: 30000
devTools: 38637
discover: 99999
discoverEnhanced: 42730
Expand Down
38 changes: 28 additions & 10 deletions ...sualizer/public/application/index_data_visualizer/ui_actions/create_field_stats_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,22 @@
* 2.0.
*/

import React from 'react';

import { i18n } from '@kbn/i18n';
import type { PresentationContainer } from '@kbn/presentation-containers';
import { tracksOverlays } from '@kbn/presentation-containers';
import type { EmbeddableApiContext } from '@kbn/presentation-publishing';
import type { UiActionsActionDefinition } from '@kbn/ui-actions-plugin/public';
import { IncompatibleActionError } from '@kbn/ui-actions-plugin/public';
import type { CoreStart } from '@kbn/core-lifecycle-browser';
import { toMountPoint } from '@kbn/react-kibana-mount';
import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
import React from 'react';
import { isDefined } from '@kbn/ml-is-defined';
import { COMMON_VISUALIZATION_GROUPING } from '@kbn/visualizations-plugin/public';
import { ENABLE_ESQL } from '@kbn/esql-utils';
import { FIELD_STATS_EMBEDDABLE_TYPE } from '../embeddables/field_stats/constants';

import type { DataVisualizerStartDependencies } from '../../common/types/data_visualizer_plugin';
import type {
FieldStatisticsTableEmbeddableApi,
FieldStatsControlsApi,
} from '../embeddables/field_stats/types';
import { FieldStatsInitializerViewType } from '../embeddables/grid_embeddable/types';
import type { FieldStatsInitialState } from '../embeddables/grid_embeddable/types';
import { getOrCreateDataViewByIndexPattern } from '../search_strategy/requests/get_data_view_by_index_pattern';
import { FieldStatisticsInitializer } from '../embeddables/field_stats/field_stats_initializer';

const parentApiIsCompatible = async (
parentApi: unknown
Expand Down Expand Up @@ -57,6 +50,21 @@ async function updatePanelFromFlyoutEdits({
initialState: FieldStatsInitialState;
fieldStatsControlsApi?: FieldStatsControlsApi;
}) {
const [
{ getOrCreateDataViewByIndexPattern },
{ FieldStatisticsInitializer },
{ tracksOverlays },
{ toMountPoint },
{ KibanaContextProvider },
{ isDefined },
] = await Promise.all([
import('../search_strategy/requests/get_data_view_by_index_pattern'),
import('../embeddables/field_stats/field_stats_initializer'),
import('@kbn/presentation-containers'),
import('@kbn/react-kibana-mount'),
import('@kbn/kibana-react-plugin/public'),
import('@kbn/ml-is-defined'),
]);
const parentApi = api.parentApi;
const overlayTracker = tracksOverlays(parentApi) ? parentApi : undefined;
const services = {
Expand Down Expand Up @@ -148,6 +156,16 @@ export function createAddFieldStatsTableAction(
);
},
async execute(context) {
const [
{ IncompatibleActionError },
{ FIELD_STATS_EMBEDDABLE_TYPE },
{ FieldStatsInitializerViewType },
] = await Promise.all([
import('@kbn/ui-actions-plugin/public'),
import('../embeddables/field_stats/constants'),
import('../embeddables/grid_embeddable/types'),
]);

const presentationContainerParent = await parentApiIsCompatible(context.embeddable);
if (!presentationContainerParent) throw new IncompatibleActionError();

Expand Down
7 changes: 3 additions & 4 deletions x-pack/plugins/data_visualizer/public/application/index_data_visualizer/ui_actions/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,13 @@
import type { CoreStart } from '@kbn/core-lifecycle-browser';
import type { UiActionsSetup } from '@kbn/ui-actions-plugin/public';
import type { DataVisualizerStartDependencies } from '../../common/types/data_visualizer_plugin';
import { createAddFieldStatsTableAction } from './create_field_stats_table';

export function registerDataVisualizerUiActions(
uiActions: UiActionsSetup,
coreStart: CoreStart,
pluginStart: DataVisualizerStartDependencies
) {
import('./create_field_stats_table').then(({ createAddFieldStatsTableAction }) => {
const addFieldStatsAction = createAddFieldStatsTableAction(coreStart, pluginStart);
uiActions.addTriggerAction('ADD_PANEL_TRIGGER', addFieldStatsAction);
});
const addFieldStatsAction = createAddFieldStatsTableAction(coreStart, pluginStart);
uiActions.addTriggerAction('ADD_PANEL_TRIGGER', addFieldStatsAction);
}