Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] [Alerts table] Fix cannot display alerts error #198914

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

benakansara
Copy link
Contributor

@benakansara benakansara commented Nov 5, 2024

Resolves #198912

Testing

  • Create ES query rule in Observability
  • Open Alert flyout of the ES query alert
  • Verify that Alert flyout opens as expected

@benakansara benakansara changed the title [Observability] [Alerts table] Fix Cannot display alerts [Observability] [Alerts table] Fix cannot display alerts error Nov 5, 2024
@benakansara benakansara self-assigned this Nov 5, 2024
@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 5, 2024
@benakansara benakansara marked this pull request as ready for review November 5, 2024 11:10
@benakansara benakansara requested a review from a team as a code owner November 5, 2024 11:10
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Nov 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

github-actions bot commented Nov 5, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@benakansara benakansara added v9.0.0 v8.16.0 backport:version Backport to applied version labels v8.17.0 v8.15.4 and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 5, 2024
@benakansara benakansara enabled auto-merge (squash) November 5, 2024 12:41
@benakansara benakansara merged commit f8c01d4 into elastic:main Nov 5, 2024
41 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11684650886

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 471.5KB 471.5KB +9.0B

cc @benakansara

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2024
…ic#198914)

Resolves elastic#198912

### Testing
- Create ES query rule in Observability
- Open Alert flyout of the ES query alert
- Verify that Alert flyout opens as expected

(cherry picked from commit f8c01d4)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2024
…ic#198914)

Resolves elastic#198912

### Testing
- Create ES query rule in Observability
- Open Alert flyout of the ES query alert
- Verify that Alert flyout opens as expected

(cherry picked from commit f8c01d4)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2024
…ic#198914)

Resolves elastic#198912

### Testing
- Create ES query rule in Observability
- Open Alert flyout of the ES query alert
- Verify that Alert flyout opens as expected

(cherry picked from commit f8c01d4)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 5, 2024
…#198914) (#198938)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Observability] [Alerts table] Fix cannot display alerts error
(#198914)](#198914)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T12:57:32Z","message":"[Observability]
[Alerts table] Fix cannot display alerts error (#198914)\n\nResolves
https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n-
Create ES query rule in Observability\r\n- Open Alert flyout of the ES
query alert\r\n- Verify that Alert flyout opens as
expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version","v8.17.0","v8.15.4"],"title":"[Observability]
[Alerts table] Fix cannot display alerts
error","number":198914,"url":"https://github.com/elastic/kibana/pull/198914","mergeCommit":{"message":"[Observability]
[Alerts table] Fix cannot display alerts error (#198914)\n\nResolves
https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n-
Create ES query rule in Observability\r\n- Open Alert flyout of the ES
query alert\r\n- Verify that Alert flyout opens as
expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198914","number":198914,"mergeCommit":{"message":"[Observability]
[Alerts table] Fix cannot display alerts error (#198914)\n\nResolves
https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n-
Create ES query rule in Observability\r\n- Open Alert flyout of the ES
query alert\r\n- Verify that Alert flyout opens as
expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 5, 2024
…198914) (#198940)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Observability] [Alerts table] Fix cannot display alerts error
(#198914)](#198914)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T12:57:32Z","message":"[Observability]
[Alerts table] Fix cannot display alerts error (#198914)\n\nResolves
https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n-
Create ES query rule in Observability\r\n- Open Alert flyout of the ES
query alert\r\n- Verify that Alert flyout opens as
expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version","v8.17.0","v8.15.4"],"title":"[Observability]
[Alerts table] Fix cannot display alerts
error","number":198914,"url":"https://github.com/elastic/kibana/pull/198914","mergeCommit":{"message":"[Observability]
[Alerts table] Fix cannot display alerts error (#198914)\n\nResolves
https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n-
Create ES query rule in Observability\r\n- Open Alert flyout of the ES
query alert\r\n- Verify that Alert flyout opens as
expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198914","number":198914,"mergeCommit":{"message":"[Observability]
[Alerts table] Fix cannot display alerts error (#198914)\n\nResolves
https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n-
Create ES query rule in Observability\r\n- Open Alert flyout of the ES
query alert\r\n- Verify that Alert flyout opens as
expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 5, 2024
…#198914) (#198939)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Observability] [Alerts table] Fix cannot display alerts error
(#198914)](#198914)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T12:57:32Z","message":"[Observability]
[Alerts table] Fix cannot display alerts error (#198914)\n\nResolves
https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n-
Create ES query rule in Observability\r\n- Open Alert flyout of the ES
query alert\r\n- Verify that Alert flyout opens as
expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version","v8.17.0","v8.15.4"],"title":"[Observability]
[Alerts table] Fix cannot display alerts
error","number":198914,"url":"https://github.com/elastic/kibana/pull/198914","mergeCommit":{"message":"[Observability]
[Alerts table] Fix cannot display alerts error (#198914)\n\nResolves
https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n-
Create ES query rule in Observability\r\n- Open Alert flyout of the ES
query alert\r\n- Verify that Alert flyout opens as
expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198914","number":198914,"mergeCommit":{"message":"[Observability]
[Alerts table] Fix cannot display alerts error (#198914)\n\nResolves
https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n-
Create ES query rule in Observability\r\n- Open Alert flyout of the ES
query alert\r\n- Verify that Alert flyout opens as
expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.15.4 v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability] [Alerts table] Cannot display alerts
4 participants