Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add registry config for failing Jest integration tests + unskip #198840

Merged
merged 6 commits into from
Nov 9, 2024

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Nov 4, 2024

Summary

Closes #192713

Add kibanaVersionCheckEnabled: false to Jest integration test config + unskip failing 9.0 Jest integration tests.

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 4, 2024
@kpollich kpollich self-assigned this Nov 4, 2024
@kpollich kpollich requested a review from a team as a code owner November 4, 2024 18:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kpollich
Copy link
Member Author

kpollich commented Nov 8, 2024

These are failing because of #186781 it looks like

@kpollich
Copy link
Member Author

kpollich commented Nov 8, 2024

I ended up setting access: public for the reset policy routes as we often request these are called from Kibana dev tools. We should probably plan to move these to a public/ prefixed endpoint in the future.

@kpollich
Copy link
Member Author

kpollich commented Nov 8, 2024

@elasticmachine merge upstream

@kpollich
Copy link
Member Author

kpollich commented Nov 8, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #46 / @ess @serverless SecuritySolution Explore Network Tls Test with Packetbeat Tls Test Ensure data is returned for FlowTarget.Source
  • [job] [logs] FTR Configs #43 / @ess @serverless SecuritySolution Timeline @skipInServerless Timeline Details Make sure that we get kpi data

Metrics [docs]

✅ unchanged

History

cc @kpollich

@kpollich kpollich merged commit 18a0933 into elastic:main Nov 9, 2024
26 checks passed
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 11, 2024
…ip (elastic#198840)

## Summary

Closes elastic#192713

Add `kibanaVersionCheckEnabled: false` to Jest integration test config +
unskip failing 9.0 Jest integration tests.

---------

Co-authored-by: Elastic Machine <[email protected]>
@juliaElastic
Copy link
Contributor

juliaElastic commented Nov 11, 2024

@kpollich I'm wondering if we should update the API routes too, currently the reset APIs include internal in the path.

export const PRECONFIGURATION_API_ROUTES = {
RESET_PATTERN: `${INTERNAL_ROOT}/reset_preconfigured_agent_policies`,
RESET_ONE_PATTERN: `${INTERNAL_ROOT}/reset_preconfigured_agent_policies/{agentPolicyId}`,
};

And we should update the KB articles that use the reset APIs to use the correct version when using curl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Fix failing 9.0 jest integration tests
5 participants