[ML] AIOps: Optimize initial load bundles. #198786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui (:ml) |
walterra
added
release_note:skip
jbudz
approved these changes
Nov 5, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @walterra |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11742814386 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Part of elastic#194171. The AIOps plugin loads quite some bundle chunks on the first Kibana load. On main it currently looks like this on page load:  This means while the `aiops.plugin.js` bundle has just 10KB, we load 290KB in total via async bundles on every Kibana full page load. This PR refactors how embeddables and UI actions get initialized to avoid loading any additional async bundles on page load. This increases `aiops.plugin.js` to ~15KB, but gets rid of all the rest!  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) (cherry picked from commit 33c303d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
rbrtj
pushed a commit
to rbrtj/kibana
that referenced
this pull request
Nov 8, 2024
Part of elastic#194171. The AIOps plugin loads quite some bundle chunks on the first Kibana load. On main it currently looks like this on page load:  This means while the `aiops.plugin.js` bundle has just 10KB, we load 290KB in total via async bundles on every Kibana full page load. This PR refactors how embeddables and UI actions get initialized to avoid loading any additional async bundles on page load. This increases `aiops.plugin.js` to ~15KB, but gets rid of all the rest!  - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ML] AIOps: Optimize initial load bundles. (#198786)](#198786) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T13:14:41Z","message":"[ML] AIOps: Optimize initial load bundles. (#198786)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/194171.\r\n\r\nThe AIOps plugin loads quite some bundle chunks on the first Kibana\r\nload. On main it currently looks like this on page load:\r\n\r\n\r\n\r\nThis means while the `aiops.plugin.js` bundle has just 10KB, we load\r\n290KB in total via async bundles on every Kibana full page load.\r\n\r\nThis PR refactors how embeddables and UI actions get initialized to\r\navoid loading any additional async bundles on page load. This increases\r\n`aiops.plugin.js` to ~15KB, but gets rid of all the rest!\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"33c303df2b8257546507b60d847c235920e70e48","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Feature:ML/AIOps","backport:version","v8.17.0"],"title":"[ML] AIOps: Optimize initial load bundles.","number":198786,"url":"https://github.com/elastic/kibana/pull/198786","mergeCommit":{"message":"[ML] AIOps: Optimize initial load bundles. (#198786)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/194171.\r\n\r\nThe AIOps plugin loads quite some bundle chunks on the first Kibana\r\nload. On main it currently looks like this on page load:\r\n\r\n\r\n\r\nThis means while the `aiops.plugin.js` bundle has just 10KB, we load\r\n290KB in total via async bundles on every Kibana full page load.\r\n\r\nThis PR refactors how embeddables and UI actions get initialized to\r\navoid loading any additional async bundles on page load. This increases\r\n`aiops.plugin.js` to ~15KB, but gets rid of all the rest!\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"33c303df2b8257546507b60d847c235920e70e48"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198786","number":198786,"mergeCommit":{"message":"[ML] AIOps: Optimize initial load bundles. (#198786)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/194171.\r\n\r\nThe AIOps plugin loads quite some bundle chunks on the first Kibana\r\nload. On main it currently looks like this on page load:\r\n\r\n\r\n\r\nThis means while the `aiops.plugin.js` bundle has just 10KB, we load\r\n290KB in total via async bundles on every Kibana full page load.\r\n\r\nThis PR refactors how embeddables and UI actions get initialized to\r\navoid loading any additional async bundles on page load. This increases\r\n`aiops.plugin.js` to ~15KB, but gets rid of all the rest!\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"33c303df2b8257546507b60d847c235920e70e48"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #194171.
The AIOps plugin loads quite some bundle chunks on the first Kibana load. On main it currently looks like this on page load:
This means while the
aiops.plugin.jsbundle has just 10KB, we load 290KB in total via async bundles on every Kibana full page load.This PR refactors how embeddables and UI actions get initialized to avoid loading any additional async bundles on page load. This increases
aiops.plugin.jsto ~15KB, but gets rid of all the rest!Checklist