[EEM] Disable authorization checks on endpoints #198695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
added
release_note:skip
klacabane
reviewed
Nov 10, 2024
x-pack/plugins/entity_manager/server/lib/entities/find_entity_definition.ts
Show resolved
Hide resolved
miltonhultgren
commented
Nov 12, 2024
|
@klacabane This LGTM but I cannot approve since I opened the PR, so feel free to approve and merge 👍🏼 |
💚 Build Succeeded
Metrics [docs]
History
cc @klacabane |
klacabane
approved these changes
Nov 12, 2024
|
@klacabane I think we should backport this to 8.x |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Disable authorization checks on all entity manager endpoints. Also makes two notable changes to the endpoints/EntityClient behaviour: - previously the EntityClient accepted a `IScopedClusterClient` and abstracted usage of asInternalUser/asCurrentUser in its methods which may result in unwanted behavior for consumers. It now only accepts an `ElasticsearchClient` that is preauthenticated by the consumers - added permissions verifications to custom definition endpoints --------- Co-authored-by: Kevin Lacabane <[email protected]> Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Disable authorization checks on all entity manager endpoints. Also makes two notable changes to the endpoints/EntityClient behaviour: - previously the EntityClient accepted a `IScopedClusterClient` and abstracted usage of asInternalUser/asCurrentUser in its methods which may result in unwanted behavior for consumers. It now only accepts an `ElasticsearchClient` that is preauthenticated by the consumers - added permissions verifications to custom definition endpoints --------- Co-authored-by: Kevin Lacabane <[email protected]> Co-authored-by: kibanamachine <[email protected]>
klacabane
added
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11893308484 |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11893308515 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
Disable authorization checks on all entity manager endpoints. Also makes two notable changes to the endpoints/EntityClient behaviour: - previously the EntityClient accepted a `IScopedClusterClient` and abstracted usage of asInternalUser/asCurrentUser in its methods which may result in unwanted behavior for consumers. It now only accepts an `ElasticsearchClient` that is preauthenticated by the consumers - added permissions verifications to custom definition endpoints --------- Co-authored-by: Kevin Lacabane <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 94d7df3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
Disable authorization checks on all entity manager endpoints. Also makes two notable changes to the endpoints/EntityClient behaviour: - previously the EntityClient accepted a `IScopedClusterClient` and abstracted usage of asInternalUser/asCurrentUser in its methods which may result in unwanted behavior for consumers. It now only accepts an `ElasticsearchClient` that is preauthenticated by the consumers - added permissions verifications to custom definition endpoints --------- Co-authored-by: Kevin Lacabane <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 94d7df3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[EEM] Disable authorization checks on endpoints (#198695)](#198695) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milton Hultgren","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-14T08:32:57Z","message":"[EEM] Disable authorization checks on endpoints (#198695)\n\nDisable authorization checks on all entity manager endpoints.\r\n\r\nAlso makes two notable changes to the endpoints/EntityClient behaviour:\r\n- previously the EntityClient accepted a `IScopedClusterClient` and\r\nabstracted usage of asInternalUser/asCurrentUser in its methods which\r\nmay result in unwanted behavior for consumers. It now only accepts an\r\n`ElasticsearchClient` that is preauthenticated by the consumers\r\n- added permissions verifications to custom definition endpoints\r\n\r\n---------\r\n\r\nCo-authored-by: Kevin Lacabane <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"94d7df3ae7ae6c482906ec8946e61a62e05b1960","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[EEM] Disable authorization checks on endpoints","number":198695,"url":"https://github.com/elastic/kibana/pull/198695","mergeCommit":{"message":"[EEM] Disable authorization checks on endpoints (#198695)\n\nDisable authorization checks on all entity manager endpoints.\r\n\r\nAlso makes two notable changes to the endpoints/EntityClient behaviour:\r\n- previously the EntityClient accepted a `IScopedClusterClient` and\r\nabstracted usage of asInternalUser/asCurrentUser in its methods which\r\nmay result in unwanted behavior for consumers. It now only accepts an\r\n`ElasticsearchClient` that is preauthenticated by the consumers\r\n- added permissions verifications to custom definition endpoints\r\n\r\n---------\r\n\r\nCo-authored-by: Kevin Lacabane <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"94d7df3ae7ae6c482906ec8946e61a62e05b1960"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198695","number":198695,"mergeCommit":{"message":"[EEM] Disable authorization checks on endpoints (#198695)\n\nDisable authorization checks on all entity manager endpoints.\r\n\r\nAlso makes two notable changes to the endpoints/EntityClient behaviour:\r\n- previously the EntityClient accepted a `IScopedClusterClient` and\r\nabstracted usage of asInternalUser/asCurrentUser in its methods which\r\nmay result in unwanted behavior for consumers. It now only accepts an\r\n`ElasticsearchClient` that is preauthenticated by the consumers\r\n- added permissions verifications to custom definition endpoints\r\n\r\n---------\r\n\r\nCo-authored-by: Kevin Lacabane <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"94d7df3ae7ae6c482906ec8946e61a62e05b1960"}}]}] BACKPORT--> Co-authored-by: Milton Hultgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable authorization checks on all entity manager endpoints.
Also makes two notable changes to the endpoints/EntityClient behaviour:
IScopedClusterClientand abstracted usage of asInternalUser/asCurrentUser in its methods which may result in unwanted behavior for consumers. It now only accepts anElasticsearchClientthat is preauthenticated by the consumers