[SecuritySolution] Fix dashboard page when the entity store state is stopped #198645
+31
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
force-pushed
the
siem-ea-196644
branch
from
5ba8f0f to
93644e1
Compare
machadoum
added
bug
machadoum
force-pushed
the
siem-ea-196644
branch
from
93644e1 to
74ca6c1
Compare
machadoum
commented
Nov 1, 2024
| loadingRiskEngine={riskEngineInitializing} | ||
| /> | ||
| )} | ||
| {(entityStore.status === 'not_installed' || entityStore.status === 'stopped') && |
There was a problem hiding this comment.
The diff is weird. But this is the only change I made here: || entityStore.status === 'stopped'
machadoum
commented
Nov 1, 2024
| </EuiFlexItem> | ||
| </> | ||
| )} | ||
| {(entityStore.status === 'not_installed' || entityStore.status === 'stopped') && |
There was a problem hiding this comment.
The diff is weird. But this is the only change I made here: || entityStore.status === 'stopped'
machadoum
added
the
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
hop-dev
approved these changes
Nov 1, 2024
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11628968777 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2024
…stopped (elastic#198645) ## Summary Fix the dashboard page when the entity store state is stopped Previously, the EntityStoreDashboardPanels component didn't account for the installed but disabled state (stopped). I made the minimum changes necessary to fix the bug, but this component needs to be refactored, unit-tested, and written in a storybook with all possible states. Technical debt Issue: elastic/security-team#11035 (cherry picked from commit 34aab05)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2024
…stopped (elastic#198645) ## Summary Fix the dashboard page when the entity store state is stopped Previously, the EntityStoreDashboardPanels component didn't account for the installed but disabled state (stopped). I made the minimum changes necessary to fix the bug, but this component needs to be refactored, unit-tested, and written in a storybook with all possible states. Technical debt Issue: elastic/security-team#11035 (cherry picked from commit 34aab05)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2024
…ate is stopped (#198645) (#198659) # Backport This will backport the following commits from `main` to `8.16`: - [[SecuritySolution] Fix dashboard page when the entity store state is stopped (#198645)](#198645) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T11:58:01Z","message":"[SecuritySolution] Fix dashboard page when the entity store state is stopped (#198645)\n\n## Summary\r\n\r\nFix the dashboard page when the entity store state is stopped\r\nPreviously, the EntityStoreDashboardPanels component didn't account for\r\nthe installed but disabled state (stopped).\r\n\r\nI made the minimum changes necessary to fix the bug, but this component\r\nneeds to be refactored, unit-tested, and written in a storybook with all\r\npossible states. Technical debt Issue:\r\nhttps://github.com/elastic/security-team/issues/11035","sha":"34aab05595115289ed7b7f8c1fad7f282292a25b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team: SecuritySolution","Theme: entity_analytics","Feature:Entity Analytics","Team:Entity Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[SecuritySolution] Fix dashboard page when the entity store state is stopped","number":198645,"url":"https://github.com/elastic/kibana/pull/198645","mergeCommit":{"message":"[SecuritySolution] Fix dashboard page when the entity store state is stopped (#198645)\n\n## Summary\r\n\r\nFix the dashboard page when the entity store state is stopped\r\nPreviously, the EntityStoreDashboardPanels component didn't account for\r\nthe installed but disabled state (stopped).\r\n\r\nI made the minimum changes necessary to fix the bug, but this component\r\nneeds to be refactored, unit-tested, and written in a storybook with all\r\npossible states. Technical debt Issue:\r\nhttps://github.com/elastic/security-team/issues/11035","sha":"34aab05595115289ed7b7f8c1fad7f282292a25b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198645","number":198645,"mergeCommit":{"message":"[SecuritySolution] Fix dashboard page when the entity store state is stopped (#198645)\n\n## Summary\r\n\r\nFix the dashboard page when the entity store state is stopped\r\nPreviously, the EntityStoreDashboardPanels component didn't account for\r\nthe installed but disabled state (stopped).\r\n\r\nI made the minimum changes necessary to fix the bug, but this component\r\nneeds to be refactored, unit-tested, and written in a storybook with all\r\npossible states. Technical debt Issue:\r\nhttps://github.com/elastic/security-team/issues/11035","sha":"34aab05595115289ed7b7f8c1fad7f282292a25b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Pablo Machado <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2024
…te is stopped (#198645) (#198660) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Fix dashboard page when the entity store state is stopped (#198645)](#198645) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T11:58:01Z","message":"[SecuritySolution] Fix dashboard page when the entity store state is stopped (#198645)\n\n## Summary\r\n\r\nFix the dashboard page when the entity store state is stopped\r\nPreviously, the EntityStoreDashboardPanels component didn't account for\r\nthe installed but disabled state (stopped).\r\n\r\nI made the minimum changes necessary to fix the bug, but this component\r\nneeds to be refactored, unit-tested, and written in a storybook with all\r\npossible states. Technical debt Issue:\r\nhttps://github.com/elastic/security-team/issues/11035","sha":"34aab05595115289ed7b7f8c1fad7f282292a25b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team: SecuritySolution","Theme: entity_analytics","Feature:Entity Analytics","Team:Entity Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[SecuritySolution] Fix dashboard page when the entity store state is stopped","number":198645,"url":"https://github.com/elastic/kibana/pull/198645","mergeCommit":{"message":"[SecuritySolution] Fix dashboard page when the entity store state is stopped (#198645)\n\n## Summary\r\n\r\nFix the dashboard page when the entity store state is stopped\r\nPreviously, the EntityStoreDashboardPanels component didn't account for\r\nthe installed but disabled state (stopped).\r\n\r\nI made the minimum changes necessary to fix the bug, but this component\r\nneeds to be refactored, unit-tested, and written in a storybook with all\r\npossible states. Technical debt Issue:\r\nhttps://github.com/elastic/security-team/issues/11035","sha":"34aab05595115289ed7b7f8c1fad7f282292a25b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198645","number":198645,"mergeCommit":{"message":"[SecuritySolution] Fix dashboard page when the entity store state is stopped (#198645)\n\n## Summary\r\n\r\nFix the dashboard page when the entity store state is stopped\r\nPreviously, the EntityStoreDashboardPanels component didn't account for\r\nthe installed but disabled state (stopped).\r\n\r\nI made the minimum changes necessary to fix the bug, but this component\r\nneeds to be refactored, unit-tested, and written in a storybook with all\r\npossible states. Technical debt Issue:\r\nhttps://github.com/elastic/security-team/issues/11035","sha":"34aab05595115289ed7b7f8c1fad7f282292a25b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Pablo Machado <[email protected]>
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 1, 2024
…stopped (elastic#198645) ## Summary Fix the dashboard page when the entity store state is stopped Previously, the EntityStoreDashboardPanels component didn't account for the installed but disabled state (stopped). I made the minimum changes necessary to fix the bug, but this component needs to be refactored, unit-tested, and written in a storybook with all possible states. Technical debt Issue: elastic/security-team#11035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the dashboard page when the entity store state is stopped
Previously, the EntityStoreDashboardPanels component didn't account for the installed but disabled state (stopped).
I made the minimum changes necessary to fix the bug, but this component needs to be refactored, unit-tested, and written in a storybook with all possible states. Technical debt Issue: https://github.com/elastic/security-team/issues/11035