[Security Solution][Endpoint Exceptions] Warning callout for incomplete code signature for endpoint exceptions #198245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkiino
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
parkiino
requested review from
a team,
tomsonpl and
paul-tavares
and removed request for
a team
paul-tavares
approved these changes
Nov 4, 2024
| @@ -184,6 +190,13 @@ export const createExceptionItemsReducer = | |||
| wildcardWarningExists: warningExists, | |||
| }; | |||
| } | |||
| case 'setPartialCodeSignature': { | |||
There was a problem hiding this comment.
I suggest you add some tests for the reducer files you changed as well.
Merged
4 tasks
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
3 tasks
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
…te code signature for endpoint exceptions (elastic#198245) ## Summary Navigate to Security Solution > Manage > Rules > Add Endpoint Exception - [x] Warning callout shown in endpoint exceptions when code signature field is incomplete (i.e. process.code_signature.subject_name w/o process.code_signature.trusted or vice versa) - [x] For mac operating systems, process.code_signature.team_id is also accepted as an equivalent to subject_name - [ ] Warning callout is also shown for nested entries for this code signature field: process.Ext.code_signature - [x] Unit Tests # Screenshots Subject name only -- warning is present  Trusted field only -- warning is present  Both subject name and trusted fields -- no warning is present 
3 tasks
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…te code signature for endpoint exceptions (elastic#198245) ## Summary Navigate to Security Solution > Manage > Rules > Add Endpoint Exception - [x] Warning callout shown in endpoint exceptions when code signature field is incomplete (i.e. process.code_signature.subject_name w/o process.code_signature.trusted or vice versa) - [x] For mac operating systems, process.code_signature.team_id is also accepted as an equivalent to subject_name - [ ] Warning callout is also shown for nested entries for this code signature field: process.Ext.code_signature - [x] Unit Tests # Screenshots Subject name only -- warning is present  Trusted field only -- warning is present  Both subject name and trusted fields -- no warning is present 
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…te code signature for endpoint exceptions (elastic#198245) ## Summary Navigate to Security Solution > Manage > Rules > Add Endpoint Exception - [x] Warning callout shown in endpoint exceptions when code signature field is incomplete (i.e. process.code_signature.subject_name w/o process.code_signature.trusted or vice versa) - [x] For mac operating systems, process.code_signature.team_id is also accepted as an equivalent to subject_name - [ ] Warning callout is also shown for nested entries for this code signature field: process.Ext.code_signature - [x] Unit Tests # Screenshots Subject name only -- warning is present  Trusted field only -- warning is present  Both subject name and trusted fields -- no warning is present 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Navigate to Security Solution > Manage > Rules > Add Endpoint Exception
Screenshots
Subject name only -- warning is present
Trusted field only -- warning is present
Both subject name and trusted fields -- no warning is present
