[Security solution] assistantKnowledgeBaseByDefault flag removed
#198180
+255
−3,170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:skip
stephmilovic
commented
Oct 31, 2024
| @@ -1,478 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
This elasticsearch_store stuff is dead code, could have been deleted in this PR: https://github.com/elastic/kibana/pull/192665/files#r1769323053
stephmilovic
commented
Oct 31, 2024
Comment on lines
-222
to
-223
| modelId: await this.getElserId(), | ||
| v2KnowledgeBaseEnabled: this.v2KnowledgeBaseEnabled, |
There was a problem hiding this comment.
These properties are unused for the noop pipeline
stephmilovic
commented
Nov 4, 2024
| this.knowledgeBaseDataStream = this.createDataStream({ | ||
| resource: 'knowledgeBase', | ||
| kibanaVersion: this.options.kibanaVersion, | ||
| fieldMap: knowledgeBaseFieldMapV2, |
There was a problem hiding this comment.
Note that the const knowledgeBaseFieldMapV2 has now been renamed to knowledgeBaseFieldMap. Therefore, createDataStream is called for the "v2" mappings on L95
stephmilovic
commented
Nov 4, 2024
| const isKnowledgeBaseInstalled = await getIsKnowledgeBaseInstalled(kbDataClient); | ||
|
|
||
| telemetry?.reportEvent(INVOKE_ASSISTANT_ERROR_EVENT.eventType, { | ||
| actionTypeId: actionTypeId ?? '', | ||
| model: request.body.model, | ||
| errorMessage: error.message, | ||
| // TODO rm actionTypeId check when llmClass for bedrock streaming is implemented |
semd
approved these changes
Nov 5, 2024
e40pud
reviewed
Nov 5, 2024
x-pack/plugins/elastic_assistant/server/ai_assistant_data_clients/knowledge_base/index.ts
Show resolved
Hide resolved
e40pud
approved these changes
Nov 5, 2024
|
Plan is to merge this on Tues Nov 12 |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11803191538 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Nov 12, 2024
…lastic#198180) (cherry picked from commit 194de0d)
stephmilovic
added a commit
that referenced
this pull request
Nov 12, 2024
…ved (#198180) (#199859) # Backport This will backport the following commits from `main` to `8.x`: - [[Security solution] `assistantKnowledgeBaseByDefault` flag removed (#198180)](#198180) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T18:10:53Z","message":"[Security solution] `assistantKnowledgeBaseByDefault` flag removed (#198180)","sha":"194de0dadb50b37e7b1be5b9228c34c9b3f0f0e6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.17.0"],"number":198180,"url":"https://github.com/elastic/kibana/pull/198180","mergeCommit":{"message":"[Security solution] `assistantKnowledgeBaseByDefault` flag removed (#198180)","sha":"194de0dadb50b37e7b1be5b9228c34c9b3f0f0e6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198180","number":198180,"mergeCommit":{"message":"[Security solution] `assistantKnowledgeBaseByDefault` flag removed (#198180)","sha":"194de0dadb50b37e7b1be5b9228c34c9b3f0f0e6"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
assistantKnowledgeBaseByDefaultflag and all of its code paths.