Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visualization:visualize:legacyHeatmapChartsLibrary from Advanced Setting #197995

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mbondyra
Copy link
Contributor

Summary

Fixes #193681

@mbondyra mbondyra added release_note:deprecation Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:version Backport to applied version labels labels Oct 28, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 28, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mbondyra mbondyra force-pushed the visualize/remove_legacy_heatmap branch 5 times, most recently from 175dbb1 to 94bc4b0 Compare October 30, 2024 12:18
@mbondyra
Copy link
Contributor Author

run docs-build

@elastic elastic deleted a comment from elasticmachine Oct 30, 2024
@mbondyra mbondyra force-pushed the visualize/remove_legacy_heatmap branch from ffdc5d8 to 1a368d9 Compare October 31, 2024 08:20
@mbondyra mbondyra force-pushed the visualize/remove_legacy_heatmap branch from f60119a to 4bd496d Compare October 31, 2024 09:15
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 31, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / Vislib Dispatch Class Test Suite Stock event handlers addClickEvent method returns a function that binds click events to a selection
  • [job] [logs] Jest Tests #10 / Vislib Dispatch Class Test Suite Stock event handlers addClickEvent method returns a function that binds click events to a selection
  • [job] [logs] Jest Tests #10 / Vislib Dispatch Class Test Suite Stock event handlers addHoverEvent method returns a function that binds mouseover events to a selection
  • [job] [logs] Jest Tests #10 / Vislib Dispatch Class Test Suite Stock event handlers addHoverEvent method returns a function that binds mouseover events to a selection
  • [job] [logs] Jest Tests #10 / Vislib Dispatch Class Test Suite Stock event handlers addMouseoutEvent method returns a function that binds mouseout events to a selection
  • [job] [logs] Jest Tests #10 / Vislib Dispatch Class Test Suite Stock event handlers addMouseoutEvent method returns a function that binds mouseout events to a selection
  • [job] [logs] Jest Tests #10 / Vislib Heatmap Chart Test Suite for series Data addSquares method should append rects
  • [job] [logs] Jest Tests #10 / Vislib Heatmap Chart Test Suite for series Data addSquares method should append rects
  • [job] [logs] Jest Tests #10 / Vislib Heatmap Chart Test Suite for series Data category axes should be rendered in reverse order
  • [job] [logs] Jest Tests #10 / Vislib Heatmap Chart Test Suite for series Data category axes should be rendered in reverse order
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite _logDomain method should return a yMin value of 1
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite _logDomain method should return a yMin value of 1
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite draw Method should be a function
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite draw Method should be a function
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getScaleType method should return a function
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getScaleType method should return a function
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYAxis method should use decimal format for small values
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYAxis method should use decimal format for small values
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method API should return a function
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method API should return a function
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method negative values should have domain between min value and 0
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method negative values should have domain between min value and 0
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method positive and negative values should have domain between min and max values
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method positive and negative values should have domain between min and max values
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method positive values should have domain between 0 and max value
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method positive values should have domain between 0 and max value
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method validate user defined values should return a decimal value
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method validate user defined values should return a decimal value
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method validate user defined values should return the user defined value
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method validate user defined values should return the user defined value
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method validate user defined values should throw a NaN error
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite getYScale Method validate user defined values should throw a NaN error
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite render Method should append a g element to the svg
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite render Method should append a g element to the svg
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite render Method should append an svg to div
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite render Method should append an svg to div
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite render Method should append ticks with text
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite render Method should append ticks with text
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite tickScale Method should return the correct number of ticks
  • [job] [logs] Jest Tests #10 / Vislib yAxis Class Test Suite tickScale Method should return the correct number of ticks

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeVislib 126 119 -7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 139 138 -1
visTypeHeatmap 3 2 -1
total -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVislib 371.6KB 358.2KB -13.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeHeatmap 10.7KB 10.5KB -216.0B
visTypeVislib 15.3KB 14.7KB -644.0B
total -860.0B
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 140 139 -1
visTypeHeatmap 3 2 -1
total -2

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:deprecation Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove visualization:visualize:legacyHeatmapChartsLibrary from Advanced Setting
2 participants