Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Security Solution][Notes] - fix createdBy filter for notes management page (#197706) #197911

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

PhilippeOberti
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

…t page (elastic#197706)

(cherry picked from commit 1065bbf)

# Conflicts:
#	x-pack/plugins/security_solution/tsconfig.json
#	x-pack/test/security_solution_api_integration/test_suites/investigation/saved_objects/tests/notes.ts
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti PhilippeOberti force-pushed the backport/8.16/pr-197706 branch from 1894089 to 42a117b Compare October 28, 2024 04:47
@PhilippeOberti PhilippeOberti force-pushed the backport/8.16/pr-197706 branch from 36f246d to d994750 Compare October 28, 2024 13:42
@PhilippeOberti PhilippeOberti merged commit 9604402 into elastic:8.16 Oct 28, 2024
34 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB +303.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionEss 11.7KB 11.8KB +9.0B
Unknown metric groups

References to deprecated APIs

id before after diff
securitySolution 448 450 +2

History

  • 💔 Build #246153 failed 36f246d2a5d2118d46cd88c886cb5cca263fb67b
  • 💔 Build #246109 failed 1894089306f9adc704a3f0032eb884af3f0576c2

@PhilippeOberti PhilippeOberti deleted the backport/8.16/pr-197706 branch October 28, 2024 15:33
PhilippeOberti added a commit that referenced this pull request Oct 28, 2024
…agement page (#197706) (#198088)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Notes] - fix createdBy filter for notes
management page
(#197706)](#197706)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T20:37:23Z","message":"[Security
Solution][Notes] - fix createdBy filter for notes management page
(#197706)","sha":"1065bbf03ca0583935d9b482939823e6b46c3c52","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"number":197706,"url":"https://github.com/elastic/kibana/pull/197706","mergeCommit":{"message":"[Security
Solution][Notes] - fix createdBy filter for notes management page
(#197706)","sha":"1065bbf03ca0583935d9b482939823e6b46c3c52"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197706","number":197706,"mergeCommit":{"message":"[Security
Solution][Notes] - fix createdBy filter for notes management page
(#197706)","sha":"1065bbf03ca0583935d9b482939823e6b46c3c52"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197911","number":197911,"state":"MERGED","mergeCommit":{"sha":"96044028628a6b3e63cb834f1ac8f82fecd7052e","message":"[8.16]
[Security Solution][Notes] - fix createdBy filter for notes management
page (#197706) (#197911)\n\n# Backport\n\nThis will backport the
following commits from `main` to `8.16`:\n- [[Security Solution][Notes]
- fix createdBy filter for notes\nmanagement
page\n(#197706)](https://github.com/elastic/kibana/pull/197706)\n\n<!---
Backport version: 8.9.8 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Philippe\nOberti\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-25T20:37:23Z\",\"message\":\"[Security\nSolution][Notes]
- fix createdBy filter for notes management
page\n(#197706)\",\"sha\":\"1065bbf03ca0583935d9b482939823e6b46c3c52\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"backport\",\"release_note:skip\",\"v9.0.0\",\"Team:Threat\nHunting:Investigations\",\"v8.16.0\"],\"number\":197706,\"url\":\"https://github.com/elastic/kibana/pull/197706\",\"mergeCommit\":{\"message\":\"[Security\nSolution][Notes]
- fix createdBy filter for notes management
page\n(#197706)\",\"sha\":\"1065bbf03ca0583935d9b482939823e6b46c3c52\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"labelRegex\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/197706\",\"number\":197706,\"mergeCommit\":{\"message\":\"[Security\nSolution][Notes]
- fix createdBy filter for notes management
page\n(#197706)\",\"sha\":\"1065bbf03ca0583935d9b482939823e6b46c3c52\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\n---------\n\nCo-authored-by:
kibanamachine <[email protected]>"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Threat Hunting:Investigations Security Solution Investigations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants