Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [OpenAPI][DOCS] Add descriptions, examples, responses for role APIs (#195527) #197889

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 25, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl requested review from a team as code owners October 25, 2024 18:30
@lcawl lcawl added the backport label Oct 25, 2024
@lcawl lcawl enabled auto-merge (squash) October 25, 2024 18:30
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kc13greiner
Copy link
Contributor

Question: why is there such a large diff in the line changes for a backport?
Screenshot 2024-10-25 at 2 45 54 PM

Original:
Screenshot 2024-10-25 at 2 45 49 PM

@kc13greiner kc13greiner self-requested a review October 25, 2024 18:47
@lcawl
Copy link
Contributor Author

lcawl commented Oct 25, 2024

Question: why is there such a large diff in the line changes for a backport?

It might be because I deleted a serverless-specific file that isn't relevant in the 8.x branch.

@lcawl lcawl requested a review from a team October 25, 2024 23:03
@jeramysoucy jeramysoucy requested review from jeramysoucy and removed request for kc13greiner October 28, 2024 14:21
@lcawl lcawl force-pushed the backport/8.x/pr-195527 branch from 1721d2d to c3012f3 Compare October 28, 2024 17:54
@lcawl lcawl force-pushed the backport/8.x/pr-195527 branch from c3012f3 to 3f0a35e Compare October 28, 2024 23:30
@lcawl lcawl merged commit c056931 into elastic:8.x Oct 29, 2024
21 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #246446 succeeded c3012f390dbc0aa10bac67d758955ce381bbafdf
  • 💚 Build #246069 succeeded 1721d2d1a508596ddd1178e4de4abdc45d656be7

@lcawl lcawl deleted the backport/8.x/pr-195527 branch October 29, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants