-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Index Management] Add support for index mode #197874
Merged
Merged
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
09a5e42
[Index Management] Add support for index mode
ElenaStoeva e781775
Add api integration tests and index mode type
ElenaStoeva ce38555
Add index mode to index template details summary
ElenaStoeva 6cbad6a
Add translated labels
ElenaStoeva adab4e3
Add functional tests
ElenaStoeva c47c473
Small fix
ElenaStoeva e55abf4
Update copy of tooltip
ElenaStoeva f0507d4
Merge branch 'main' into im/index-mode-support
ElenaStoeva 249c9d3
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine 0bbec28
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 19e0e1d
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine c059169
Fix failing jest tests
ElenaStoeva 71566ec
Merge branch 'im/index-mode-support' of https://github.com/ElenaStoev…
ElenaStoeva 8eef79b
Resolve type check errors
ElenaStoeva 5d6a396
Fix functional tests
ElenaStoeva a47b5e6
Merge branch 'main' into im/index-mode-support
ElenaStoeva 5b402ef
Merge branch 'main' into im/index-mode-support
ElenaStoeva 2590ba4
Fix failing test and type error, add suggested test
ElenaStoeva ab31a8f
Merge branch 'main' into im/index-mode-support
ElenaStoeva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
x-pack/plugins/index_management/public/application/lib/index_mode_labels.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { i18n } from '@kbn/i18n'; | ||
|
||
export const getIndexModeLabel = (mode?: string | null) => { | ||
switch (mode) { | ||
case 'standard': | ||
case null: | ||
mattkime marked this conversation as resolved.
Show resolved
Hide resolved
|
||
case undefined: | ||
return i18n.translate('xpack.idxMgmt.indexModeLabels.standardModeLabel', { | ||
defaultMessage: 'Standard', | ||
}); | ||
case 'logsdb': | ||
return i18n.translate('xpack.idxMgmt.indexModeLabels.logsdbModeLabel', { | ||
defaultMessage: 'LogsDB', | ||
}); | ||
case 'time_series': | ||
return i18n.translate('xpack.idxMgmt.indexModeLabels.tsdbModeLabel', { | ||
defaultMessage: 'Time series', | ||
}); | ||
default: | ||
return mode; | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
import React from 'react'; | ||
import { EuiTablePagination } from '@elastic/eui'; | ||
import { useEuiTablePersist } from '@kbn/shared-ux-table-persist'; | ||
import { IndexModule } from '../../../../../../common'; | ||
import { Index } from '../../../../../../common'; | ||
|
||
interface IndexTablePaginationProps { | ||
pager: any; | ||
|
@@ -27,7 +27,7 @@ export const IndexTablePagination = ({ | |
readURLParams, | ||
setURLParam, | ||
}: IndexTablePaginationProps) => { | ||
const { pageSize, onTableChange } = useEuiTablePersist<IndexModule>({ | ||
const { pageSize, onTableChange } = useEuiTablePersist<Index>({ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems here we used an incorrect type - it should be |
||
tableId: 'indices', | ||
initialPageSize: pager.itemsPerPage, | ||
pageSizeOptions: PAGE_SIZE_OPTIONS, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this manual type in favor of
IndicesIndexSettingsKeys
type from Es client since the manual one has missing properties (e.g.mode
).