Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Remove visualization:colorMapping advanced setting #197802

Merged
merged 16 commits into from
Nov 21, 2024
Merged

[Visualize] Remove visualization:colorMapping advanced setting #197802

merged 16 commits into from
Nov 21, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Oct 25, 2024 •
edited
Loading

Summary

Fixes #193682
Removes the deprecated visualization:colorMapping advanced setting.

Release notes

Thevisualization:colorMapping advanced setting for TSVB and Visualize charts has been removed. Users are encouraged to switch to Lens charts, which offer a more advanced, per-chart color mapping feature with enhanced configuration options. For more details, refer to PR #162389.

@mbondyra mbondyra added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:deprecation Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:version Backport to applied version labels labels Oct 25, 2024
@mbondyra mbondyra changed the title [Visualize] deprecate visualize:color.mapping setting [Visualize] Remove visualization:colorMapping advanced setting Oct 25, 2024
@mbondyra mbondyra force-pushed the visualize/deprecate_color_mapping_setting branch 3 times, most recently from 5db080f to 1b3aa5b Compare October 28, 2024 10:35
@elastic elastic deleted a comment from elasticmachine Oct 28, 2024
@mbondyra mbondyra force-pushed the visualize/deprecate_color_mapping_setting branch from 1b3aa5b to 4911980 Compare October 28, 2024 12:13
@mbondyra
Copy link
Contributor Author

run docs-build

@mbondyra mbondyra marked this pull request as ready for review October 28, 2024 16:00
@mbondyra mbondyra requested review from a team as code owners October 28, 2024 16:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra force-pushed the visualize/deprecate_color_mapping_setting branch from 0bddc81 to cb7e36d Compare October 31, 2024 08:21
dej611
dej611 reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First code review pass, left some comments.

src/plugins/charts/public/services/mapped_colors/mapped_colors.ts Outdated Show resolved Hide resolved
@mbondyra mbondyra force-pushed the visualize/deprecate_color_mapping_setting branch from cb7e36d to 4ab47fc Compare November 11, 2024 13:30
@mbondyra mbondyra marked this pull request as draft November 11, 2024 14:04
@elastic elastic deleted a comment from elasticmachine Nov 11, 2024
@mbondyra mbondyra force-pushed the visualize/deprecate_color_mapping_setting branch from 027a6e0 to e02560d Compare November 12, 2024 06:47
@mbondyra mbondyra marked this pull request as ready for review November 12, 2024 13:36
@nickofthyme nickofthyme requested a review from a team as a code owner November 14, 2024 21:49
@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) labels Nov 14, 2024
@nreese

This comment was marked as resolved.

Sign in to view
@nickofthyme nickofthyme added backport:skip This commit does not require backporting and removed backport:version Backport to applied version labels labels Nov 14, 2024
@nickofthyme nickofthyme removed the request for review from a team November 19, 2024 15:58
@nickofthyme nickofthyme mentioned this pull request Nov 19, 2024
Open
@nickofthyme nickofthyme enabled auto-merge (squash) November 21, 2024 18:41
@nickofthyme nickofthyme merged commit 407f6be into elastic:main Nov 21, 2024
25 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / Case Owner Selection renders all options

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
charts 129 127 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
charts 253 252 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
charts 9.4KB 9.5KB +18.0B
visTypeVislib 371.6KB 371.4KB -229.0B
total -211.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
charts 10 9 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 45.3KB 43.1KB -2.2KB
Unknown metric groups

API count

id before after diff
charts 268 267 -1

History

paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@mbondyra @paulinashakirova
[Visualize] Remove visualization:colorMapping advanced setting (ela…
f1abe4d 
…stic#197802)

## Summary

Fixes elastic#193682 Removes the deprecated `visualization:colorMapping` advanced setting.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@mbondyra @CAWilson94
[Visualize] Remove visualization:colorMapping advanced setting (ela…
b7d6bc0 
…stic#197802)

## Summary

Fixes elastic#193682 Removes the deprecated `visualization:colorMapping` advanced setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 left review comments

@dej611 dej611 dej611 left review comments

@nickofthyme nickofthyme nickofthyme approved these changes

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:deprecation Team:Visualizations Visualization editors, elastic-charts and infrastructure v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove visualization:colorMapping Advanced Setting
8 participants
@mbondyra @elasticmachine @nreese @dej611 @markov00 @afharo @nickofthyme @kibanamachine