Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(o11y): add missing access options to routes #197511

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Oct 23, 2024

Resolves #192730

🧀 Summary

This PR adds the missing access option in some o11y routes.

@kdelemme kdelemme added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 Team:obs-ux-management Observability Management User Experience Team labels Oct 23, 2024
@kdelemme kdelemme marked this pull request as ready for review October 23, 2024 18:28
@kdelemme kdelemme requested a review from a team as a code owner October 23, 2024 18:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kdelemme kdelemme added the release_note:skip Skip the PR/issue when compiling release notes label Oct 23, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / when on the endpoint list page when there are policies, but no hosts should show loading spinner while Agent Policies are loading

Metrics [docs]

✅ unchanged

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 24, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme merged commit b3d5c4b into elastic:main Oct 24, 2024
35 checks passed
@kdelemme kdelemme deleted the chore/add-access-observability-routes branch October 24, 2024 13:15
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11500088729

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
…97637)

# Backport

This will backport the following commits from `main` to `8.x`:
- [chore(o11y): add missing access options to routes
(#197511)](#197511)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T13:15:05Z","message":"chore(o11y):
add missing access options to routes
(#197511)","sha":"b3d5c4b46e2f9df7a28bcc3b5b61a132ffdcc0f1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"chore(o11y):
add missing access options to
routes","number":197511,"url":"https://github.com/elastic/kibana/pull/197511","mergeCommit":{"message":"chore(o11y):
add missing access options to routes
(#197511)","sha":"b3d5c4b46e2f9df7a28bcc3b5b61a132ffdcc0f1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197511","number":197511,"mergeCommit":{"message":"chore(o11y):
add missing access options to routes
(#197511)","sha":"b3d5c4b46e2f9df7a28bcc3b5b61a132ffdcc0f1"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability plugin] Use correct access: tags in observability plugin API routes
4 participants