-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(o11y): add missing access options to routes #197511
Merged
kdelemme
merged 3 commits into
elastic:main
from
kdelemme:chore/add-access-observability-routes
Oct 24, 2024
Merged
chore(o11y): add missing access options to routes #197511
kdelemme
merged 3 commits into
elastic:main
from
kdelemme:chore/add-access-observability-routes
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
v8.17.0
Team:obs-ux-management
Observability Management User Experience Team
labels
Oct 23, 2024
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Oct 23, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
maryam-saeidi
approved these changes
Oct 24, 2024
botelastic
bot
added
the
ci:project-deploy-observability
Create an Observability project
label
Oct 24, 2024
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11500088729 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
(cherry picked from commit b3d5c4b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
…97637) # Backport This will backport the following commits from `main` to `8.x`: - [chore(o11y): add missing access options to routes (#197511)](#197511) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T13:15:05Z","message":"chore(o11y): add missing access options to routes (#197511)","sha":"b3d5c4b46e2f9df7a28bcc3b5b61a132ffdcc0f1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"chore(o11y): add missing access options to routes","number":197511,"url":"https://github.com/elastic/kibana/pull/197511","mergeCommit":{"message":"chore(o11y): add missing access options to routes (#197511)","sha":"b3d5c4b46e2f9df7a28bcc3b5b61a132ffdcc0f1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197511","number":197511,"mergeCommit":{"message":"chore(o11y): add missing access options to routes (#197511)","sha":"b3d5c4b46e2f9df7a28bcc3b5b61a132ffdcc0f1"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
ci:project-deploy-observability
Create an Observability project
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-management
Observability Management User Experience Team
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #192730
🧀 Summary
This PR adds the missing access option in some o11y routes.