Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping flaky lab mode test #19742

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Skipping flaky lab mode test #19742

merged 2 commits into from
Jun 7, 2018

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Jun 7, 2018

Related to #17408

@elastic/kibana-visualizations

@tylersmalley
Copy link
Contributor

Can you make a corresponding issue to fix the test and have it re-enabled?

@thomasneirynck thomasneirynck self-requested a review June 7, 2018 19:24
@kobelb
Copy link
Contributor Author

kobelb commented Jun 7, 2018

You got it @tylersmalley - #19743

@timroes
Copy link
Contributor

timroes commented Jun 7, 2018

The flakyness effects btw all tests that load a saved search in Discovery. But I think disabling this one should already help a lot, I've seen the other Discovery tests fail - for whatever reason - way less often.

@kobelb kobelb merged commit cb4240a into elastic:master Jun 7, 2018
@kobelb kobelb deleted the skip-lab-mode branch June 7, 2018 20:28
kobelb added a commit to kobelb/kibana that referenced this pull request Jun 7, 2018
* Skipping lab mode tests

* Update _lab_mode.js
kobelb added a commit that referenced this pull request Jun 7, 2018
* Skipping lab mode tests

* Update _lab_mode.js
@kobelb kobelb added v7.0.0 v6.4.0 non-issue Indicates to automation that a pull request should not appear in the release notes labels Jun 7, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

kindsun pushed a commit that referenced this pull request Jun 12, 2018
* Skipping lab mode tests

* Update _lab_mode.js
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
* Skipping lab mode tests

* Update _lab_mode.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue Indicates to automation that a pull request should not appear in the release notes v6.4.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants