-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Memory usage: Functional tests #197415
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.buildkite/ftr_platform_stateful_configs.yml
await ml.memoryUsage.selectTab('memory-usage'); | ||
await ml.memoryUsage.assertTreeChartExists(); | ||
|
||
await ml.memoryUsage.clearSelectedChartItems(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding a step where you leave just the Anomaly Detection Job item and assert the tree chart exists, before clearing all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not sure what you mean exactly.
This test is responsible for ensuring that the chart is displayed properly in the memory usage
tab.
Then, it clears the combo box and checks if the chart displays an empty state.
The same thing was done earlier, but for a chart inside an expanded row of a particular node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11517513172 |
## Summary Functional tests for `memory usage` page in ML. (cherry picked from commit 479280c)
## Summary Functional tests for `memory usage` page in ML. (cherry picked from commit 479280c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[ML] Memory usage: Functional tests (#197415)](#197415) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T11:39:38Z","message":"[ML] Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional tests for `memory usage` page in ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Memory usage: Functional tests","number":197415,"url":"https://github.com/elastic/kibana/pull/197415","mergeCommit":{"message":"[ML] Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional tests for `memory usage` page in ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197415","number":197415,"mergeCommit":{"message":"[ML] Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional tests for `memory usage` page in ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
# Backport This will backport the following commits from `main` to `8.16`: - [[ML] Memory usage: Functional tests (#197415)](#197415) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T11:39:38Z","message":"[ML] Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional tests for `memory usage` page in ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Memory usage: Functional tests","number":197415,"url":"https://github.com/elastic/kibana/pull/197415","mergeCommit":{"message":"[ML] Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional tests for `memory usage` page in ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197415","number":197415,"mergeCommit":{"message":"[ML] Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional tests for `memory usage` page in ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
Summary
Functional tests for
memory usage
page in ML.