Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] API tests for ML's _has_privileges #197274

Merged

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Oct 22, 2024

Calls ML's _has_privileges endpoint with various users.
Also ensures upgrade mode status is correctly returned.

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 22, 2024
@jgowdyelastic jgowdyelastic self-assigned this Oct 22, 2024
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner October 22, 2024 15:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rbrtj rbrtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jgowdyelastic jgowdyelastic merged commit fc812e3 into elastic:main Oct 23, 2024
36 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11475555276

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2024
Calls ML's `_has_privileges` endpoint with various users.
Also ensures upgrade mode status is correctly returned.

(cherry picked from commit fc812e3)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2024
Calls ML's `_has_privileges` endpoint with various users.
Also ensures upgrade mode status is correctly returned.

(cherry picked from commit fc812e3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 23, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] API tests for ML's _has_privileges
(#197274)](#197274)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T07:57:46Z","message":"[ML]
API tests for ML's _has_privileges (#197274)\n\nCalls ML's
`_has_privileges` endpoint with various users.\r\nAlso ensures upgrade
mode status is correctly
returned.","sha":"fc812e33d85691d76e657f8056b18d79a9f860b1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
API tests for ML's
_has_privileges","number":197274,"url":"https://github.com/elastic/kibana/pull/197274","mergeCommit":{"message":"[ML]
API tests for ML's _has_privileges (#197274)\n\nCalls ML's
`_has_privileges` endpoint with various users.\r\nAlso ensures upgrade
mode status is correctly
returned.","sha":"fc812e33d85691d76e657f8056b18d79a9f860b1"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197274","number":197274,"mergeCommit":{"message":"[ML]
API tests for ML's _has_privileges (#197274)\n\nCalls ML's
`_has_privileges` endpoint with various users.\r\nAlso ensures upgrade
mode status is correctly
returned.","sha":"fc812e33d85691d76e657f8056b18d79a9f860b1"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 23, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [[ML] API tests for ML&#x27;s _has_privileges
(#197274)](#197274)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T07:57:46Z","message":"[ML]
API tests for ML's _has_privileges (#197274)\n\nCalls ML's
`_has_privileges` endpoint with various users.\r\nAlso ensures upgrade
mode status is correctly
returned.","sha":"fc812e33d85691d76e657f8056b18d79a9f860b1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
API tests for ML's
_has_privileges","number":197274,"url":"https://github.com/elastic/kibana/pull/197274","mergeCommit":{"message":"[ML]
API tests for ML's _has_privileges (#197274)\n\nCalls ML's
`_has_privileges` endpoint with various users.\r\nAlso ensures upgrade
mode status is correctly
returned.","sha":"fc812e33d85691d76e657f8056b18d79a9f860b1"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197274","number":197274,"mergeCommit":{"message":"[ML]
API tests for ML's _has_privileges (#197274)\n\nCalls ML's
`_has_privileges` endpoint with various users.\r\nAlso ensures upgrade
mode status is correctly
returned.","sha":"fc812e33d85691d76e657f8056b18d79a9f860b1"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants