[FTR][Ownership] Upgrade Assistant, Watcher, etc #197253
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigned upgrade_assistant due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/upgrade_assistant/kibana.jsonc#L4 Assigned watcher due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/watcher/kibana.jsonc#L4 Assigned ingest_pipelines due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/ingest_pipelines/kibana.jsonc#L4 Assigned security solutions services only due to the name Assigned detections_response due to the name Assigned dashboard due to the name Assigned index management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_management/kibana.jsonc#L4 Assigned ilm due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_lifecycle_management/kibana.jsonc#L4 Contributes to: elastic#194817
wayneseymour
added
release_note:skip
12 tasks
dmlemeshko
reviewed
Oct 22, 2024
.github/CODEOWNERS
Outdated
| @@ -1342,6 +1343,9 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai | |||
| /.eslintignore @elastic/kibana-operations | |||
|
|
|||
| # Appex QA | |||
| /x-pack/test/functional/config.*.js @elastic/appex-qa | |||
| /x-pack/test/functional/config.*.ts @elastic/appex-qa | |||
There was a problem hiding this comment.
is it possible to use /x-pack/test/functional/config.*.* or convert those few to .ts?
There was a problem hiding this comment.
Converting would be way outside of the scope and I've thousands more assignments to go through.
But a better glob sounds great!
dmlemeshko
reviewed
Oct 22, 2024
| @@ -1342,6 +1343,9 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai | |||
| /.eslintignore @elastic/kibana-operations | |||
|
|
|||
| # Appex QA | |||
| /x-pack/test/functional/config.*.js @elastic/appex-qa | |||
| /x-pack/test/functional/config.*.ts @elastic/appex-qa | |||
| /x-pack/test/api_integration/ftr_provider_context.d.ts @elastic/appex-qa # Maybe this should be a glob? | |||
There was a problem hiding this comment.
good point, not sure how many of those are not owned by us
There was a problem hiding this comment.
Yeah at first glance, I would guess many would be owned by us.
But not certain :(
nreese
approved these changes
Oct 22, 2024
YulNaumenko
approved these changes
Oct 23, 2024
banderror
approved these changes
Oct 23, 2024
yctercero
approved these changes
Oct 24, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assigning ownership to as many files as possible, with as few reviewers as possible.
Assignment Reasons
Assigned upgrade_assistant due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/upgrade_assistant/kibana.jsonc#L4
Assigned watcher due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/watcher/kibana.jsonc#L4
Assigned ingest_pipelines due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/ingest_pipelines/kibana.jsonc#L4
Assigned security solutions services only due to the name
Assigned detections_response due to the name
Assigned dashboard due to the name
Assigned index management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_management/kibana.jsonc#L4
Assigned ilm due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_lifecycle_management/kibana.jsonc#L4
Contributes to: #194817