Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Show rules created in Obs Rules page !! #197215

Merged
merged 3 commits into from
Oct 23, 2024
Merged

[Synthetics] Show rules created in Obs Rules page !! #197215

merged 3 commits into from
Oct 23, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 22, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #197071

@shahzad31 shahzad31 requested review from a team as code owners October 22, 2024 11:20
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Oct 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes labels Oct 22, 2024
cnasikas
cnasikas approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an authorization stand point LGTM!

@shahzad31 shahzad31 requested a review from a team as a code owner October 22, 2024 15:31
@kc13greiner kc13greiner self-requested a review October 22, 2024 16:23
kc13greiner
kc13greiner approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeOwners review - LGTM!

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 845cf1f
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197215-845cf1f1a185

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/rule-data-utils 133 135 +2
Unknown metric groups

API count

id before after diff
@kbn/rule-data-utils 136 138 +2

History

@shahzad31 shahzad31 merged commit 9c4e67c into elastic:main Oct 23, 2024
25 checks passed
@shahzad31 shahzad31 deleted the fix-rules-synth-obs-serv branch October 23, 2024 11:22
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11478831883

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2024
@shahzad31
[Synthetics] Show rules created in Obs Rules page !! (elastic#197215)
eec3c32 
## Summary

Fixes elastic#197071

---------

Co-authored-by: Christos Nasikas <[email protected]>
(cherry picked from commit 9c4e67c)
@kibanamachine kibanamachine mentioned this pull request Oct 23, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2024
@shahzad31
[Synthetics] Show rules created in Obs Rules page !! (elastic#197215)
e4783e1 
## Summary

Fixes elastic#197071

---------

Co-authored-by: Christos Nasikas <[email protected]>
(cherry picked from commit 9c4e67c)
@kibanamachine kibanamachine mentioned this pull request Oct 23, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2024
@shahzad31
[Synthetics] Show rules created in Obs Rules page !! (elastic#197215)
70c9edd 
## Summary

Fixes elastic#197071

---------

Co-authored-by: Christos Nasikas <[email protected]>
(cherry picked from commit 9c4e67c)
@kibanamachine kibanamachine mentioned this pull request Oct 23, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Oct 23, 2024
Merged
kibanamachine added a commit that referenced this pull request Oct 23, 2024
@kibanamachine @shahzad31
[8.15] [Synthetics] Show rules created in Obs Rules page !! (#197215) (…
10dce92 
…#197409)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Synthetics] Show rules created in Obs Rules page !!
(#197215)](#197215)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T11:22:24Z","message":"[Synthetics]
Show rules created in Obs Rules page !! (#197215)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/197071\r\n\r\n---------\r\n\r\nCo-authored-by:
Christos Nasikas
<[email protected]>","sha":"9c4e67c985cf917a3664151d427a4fcdef0563d6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Show rules created in Obs Rules page
!!","number":197215,"url":"https://github.com/elastic/kibana/pull/197215","mergeCommit":{"message":"[Synthetics]
Show rules created in Obs Rules page !! (#197215)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/197071\r\n\r\n---------\r\n\r\nCo-authored-by:
Christos Nasikas
<[email protected]>","sha":"9c4e67c985cf917a3664151d427a4fcdef0563d6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197215","number":197215,"mergeCommit":{"message":"[Synthetics]
Show rules created in Obs Rules page !! (#197215)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/197071\r\n\r\n---------\r\n\r\nCo-authored-by:
Christos Nasikas
<[email protected]>","sha":"9c4e67c985cf917a3664151d427a4fcdef0563d6"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 23, 2024
@kibanamachine @shahzad31
[8.16] [Synthetics] Show rules created in Obs Rules page !! (#197215) (…
1cb79c1 
…#197410)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Synthetics] Show rules created in Obs Rules page !!
(#197215)](#197215)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T11:22:24Z","message":"[Synthetics]
Show rules created in Obs Rules page !! (#197215)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/197071\r\n\r\n---------\r\n\r\nCo-authored-by:
Christos Nasikas
<[email protected]>","sha":"9c4e67c985cf917a3664151d427a4fcdef0563d6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Show rules created in Obs Rules page
!!","number":197215,"url":"https://github.com/elastic/kibana/pull/197215","mergeCommit":{"message":"[Synthetics]
Show rules created in Obs Rules page !! (#197215)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/197071\r\n\r\n---------\r\n\r\nCo-authored-by:
Christos Nasikas
<[email protected]>","sha":"9c4e67c985cf917a3664151d427a4fcdef0563d6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197215","number":197215,"mergeCommit":{"message":"[Synthetics]
Show rules created in Obs Rules page !! (#197215)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/197071\r\n\r\n---------\r\n\r\nCo-authored-by:
Christos Nasikas
<[email protected]>","sha":"9c4e67c985cf917a3664151d427a4fcdef0563d6"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 23, 2024
@kibanamachine @shahzad31
[8.x] [Synthetics] Show rules created in Obs Rules page !! (#197215) (#…
ce8ef51 
…197411)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Show rules created in Obs Rules page !!
(#197215)](#197215)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T11:22:24Z","message":"[Synthetics]
Show rules created in Obs Rules page !! (#197215)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/197071\r\n\r\n---------\r\n\r\nCo-authored-by:
Christos Nasikas
<[email protected]>","sha":"9c4e67c985cf917a3664151d427a4fcdef0563d6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Show rules created in Obs Rules page
!!","number":197215,"url":"https://github.com/elastic/kibana/pull/197215","mergeCommit":{"message":"[Synthetics]
Show rules created in Obs Rules page !! (#197215)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/197071\r\n\r\n---------\r\n\r\nCo-authored-by:
Christos Nasikas
<[email protected]>","sha":"9c4e67c985cf917a3664151d427a4fcdef0563d6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197215","number":197215,"mergeCommit":{"message":"[Synthetics]
Show rules created in Obs Rules page !! (#197215)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/197071\r\n\r\n---------\r\n\r\nCo-authored-by:
Christos Nasikas
<[email protected]>","sha":"9c4e67c985cf917a3664151d427a4fcdef0563d6"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benakansara benakansara benakansara approved these changes

@kc13greiner kc13greiner kc13greiner approved these changes

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.15.4 v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Synthetics] Monitor status Rules created in Serverless Observability Rules page doesn't appears in list
6 participants
@shahzad31 @elasticmachine @kibanamachine @cnasikas @kc13greiner @benakansara