Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Sending the Agentless API the deployment_mode information #196955

Conversation

seanrathier
Copy link
Contributor

@seanrathier seanrathier commented Oct 18, 2024

Summary

When the deployment_modes agentless is available and the user selects the Agentless installation, we send the Agentless API the integration's deployment_modes values for organization, division, and team attributes.

The business rules allow for a single integration policy template to have agentless mode while the other is not agentless, therefore the integration UI needs to send the selected policy name to the setup_technology hook's handleSetupTechnologyChange

We are using the NewAgentPolicy types global_data_tags to hold the organization, division, and team name and the AgentlessAgentService.createAgent function reads the tags and passes them to the Agentless API by sending the data in the body of the request under the label attribute

Checklist

Delete any items that are not applicable to this PR.

@seanrathier seanrathier added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) 8.17 candidate labels Oct 18, 2024
@seanrathier seanrathier self-assigned this Oct 18, 2024
@seanrathier seanrathier marked this pull request as ready for review October 21, 2024 18:29
@seanrathier seanrathier requested review from a team as code owners October 21, 2024 18:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 21, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / useSetupTechnology create page flow calls handleSetupTechnologyChange when setupTechnology changes
  • [job] [logs] Jest Tests #7 / useSetupTechnology create page flow calls handleSetupTechnologyChange when setupTechnology changes

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 508.7KB 508.7KB +18.0B
fleet 1.7MB 1.7MB +398.0B
total +416.0B

History

cc @seanrathier

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@seanrathier seanrathier force-pushed the 10436-send-the-agentless-api-organization-division-team branch from fa19751 to 0671ae8 Compare October 23, 2024 21:38
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanrathier seanrathier merged commit 1820eaf into elastic:main Oct 24, 2024
26 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11500154313

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
…information (#196955) (#197638)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Security] Sending the Agentless API the deployment_mode
information (#196955)](#196955)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"seanrathier","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T13:18:45Z","message":"[Cloud
Security] Sending the Agentless API the deployment_mode information
(#196955)","sha":"1820eafcdfc35d2a7e506d3960029e5abc7e34d7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud
Security","backport:prev-minor","8.17 candidate"],"title":"[Cloud
Security] Sending the Agentless API the deployment_mode
information","number":196955,"url":"https://github.com/elastic/kibana/pull/196955","mergeCommit":{"message":"[Cloud
Security] Sending the Agentless API the deployment_mode information
(#196955)","sha":"1820eafcdfc35d2a7e506d3960029e5abc7e34d7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196955","number":196955,"mergeCommit":{"message":"[Cloud
Security] Sending the Agentless API the deployment_mode information
(#196955)","sha":"1820eafcdfc35d2a7e506d3960029e5abc7e34d7"}}]}]
BACKPORT-->

Co-authored-by: seanrathier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.17 candidate backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related Team:Fleet Team label for Observability Data Collection Fleet team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants