Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Security Solution][Notes] - fix an issue that breaks the notes management page, an enum value was missing from the api (#196912) #196935

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

…ement page, an enum value was missing from the api (elastic#196912)

## Summary

_**Notes: please ignore the spaces introduced in the first commit,
Webstorm is trying to be smart... CI should take care of fixing that in
a second commit shortly**_

This PR fixes a small issue that prevents the notes management page to
load. The issue comes from the fact that one of the enum values passed
to filter notes was missing from the open api spec. This issue was
introduced in this recent
[PR](elastic#195501).

Current notes management borken page
![Screenshot 2024-10-18 at 10 30
13 AM](https://github.com/user-attachments/assets/4926a62f-1ebf-4698-8a13-bf761d77f4ba)

This is the error in the network tab
![Screenshot 2024-10-18 at 10 30
29 AM](https://github.com/user-attachments/assets/90b56246-c116-4050-bcfa-2c6668274e74)

This PR fixes the issue
![Screenshot 2024-10-18 at 10 27
01 AM](https://github.com/user-attachments/assets/7d3338ce-ad73-4be5-b94c-15bcf0234680)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit bf7c5aa)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.1MB 21.1MB +6.0B

cc @PhilippeOberti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants