Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Pipelines] Update copy in Manage processors #196923

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Ingest Pipelines] Update copy in Manage processors #196923

wants to merge 1 commit into from
+13 −8

Conversation

ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Oct 18, 2024 •
edited
Loading

Summary

This PR adds some copy changes to the Manage processors pages.

  1. Empty prompt
  • Width and padding of the prompt is adjusted so that "IP" in the title starts in the 2nd line
  • Description is updated
Screenshot 2024-10-18 at 17 00 53
  1. Add database modal
  • Copy in callouts is updated
  • The help text of the "Type" field is updated
  • The text in the "Database already exists" error callout is updated
Screenshot 2024-10-18 at 17 24 32 Screenshot 2024-10-18 at 17 24 43
  1. Manage processors page
  • The title of the page is changed from "GeoIP" to "IP Location"
Screenshot 2024-10-18 at 17 20 01

@ElenaStoeva ElenaStoeva added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Ingest Node Pipelines Ingest node pipelines management backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 18, 2024
@ElenaStoeva ElenaStoeva self-assigned this Oct 18, 2024
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner October 18, 2024 16:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ingestPipelines 339 357 +18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 392.6KB 404.5KB +11.9KB

cc @ElenaStoeva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovana-andjelkovic jovana-andjelkovic Awaiting requested review from jovana-andjelkovic

At least 1 approving review is required to merge this pull request.

Assignees

@ElenaStoeva ElenaStoeva

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElenaStoeva @elasticmachine