[Security Solution][Quality Gate Monitoring] Fixed override for monitoring pipeline #196841
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkirchan
added
release_note:skip
dkirchan
requested review from
MadameSheema,
patrykkopycinski,
maximpn and
banderror
as code owners
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
dkirchan
added
the
backport:prev-minor
|
/ci |
MadameSheema
approved these changes
Oct 18, 2024
💚 Build Succeeded
Metrics [docs]
cc @dkirchan |
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11403513616 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…oring pipeline (elastic#196841) ## Summary Instead of just quality gate for security, a monitoring pipeline has been introduced which acts like quality gate but is overriding the kibana image with the latest [dev-devenv version](https://github.com/elastic/serverless-gitops/blob/79862d97b1b1d3a97c0d8e2091ea06b9aed43f0c/services/kibana/versions.yaml#L4). This change addresses the changes needed for this new pipeline taking under consideration the environmental variable `KIBANA_MKI_QUALITY_GATE_MONITORING` which if present, it defines that we do run the set of tests for quality gate but with an override. (cherry picked from commit 6091542)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
… monitoring pipeline (#196841) (#196861) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Quality Gate Monitoring] Fixed override for monitoring pipeline (#196841)](#196841) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"dkirchan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T12:16:10Z","message":"[Security Solution][Quality Gate Monitoring] Fixed override for monitoring pipeline (#196841)\n\n## Summary\r\n\r\nInstead of just quality gate for security, a monitoring pipeline has\r\nbeen introduced which acts like quality gate but is overriding the\r\nkibana image with the latest [dev-devenv\r\nversion](https://github.com/elastic/serverless-gitops/blob/79862d97b1b1d3a97c0d8e2091ea06b9aed43f0c/services/kibana/versions.yaml#L4).\r\n\r\nThis change addresses the changes needed for this new pipeline taking\r\nunder consideration the environmental variable\r\n`KIBANA_MKI_QUALITY_GATE_MONITORING` which if present, it defines that\r\nwe do run the set of tests for quality gate but with an override.","sha":"60915420114fe35db940df268660503c93adae52","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","v8.16.0","v8.17.0"],"title":"[Security Solution][Quality Gate Monitoring] Fixed override for monitoring pipeline","number":196841,"url":"https://github.com/elastic/kibana/pull/196841","mergeCommit":{"message":"[Security Solution][Quality Gate Monitoring] Fixed override for monitoring pipeline (#196841)\n\n## Summary\r\n\r\nInstead of just quality gate for security, a monitoring pipeline has\r\nbeen introduced which acts like quality gate but is overriding the\r\nkibana image with the latest [dev-devenv\r\nversion](https://github.com/elastic/serverless-gitops/blob/79862d97b1b1d3a97c0d8e2091ea06b9aed43f0c/services/kibana/versions.yaml#L4).\r\n\r\nThis change addresses the changes needed for this new pipeline taking\r\nunder consideration the environmental variable\r\n`KIBANA_MKI_QUALITY_GATE_MONITORING` which if present, it defines that\r\nwe do run the set of tests for quality gate but with an override.","sha":"60915420114fe35db940df268660503c93adae52"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196841","number":196841,"mergeCommit":{"message":"[Security Solution][Quality Gate Monitoring] Fixed override for monitoring pipeline (#196841)\n\n## Summary\r\n\r\nInstead of just quality gate for security, a monitoring pipeline has\r\nbeen introduced which acts like quality gate but is overriding the\r\nkibana image with the latest [dev-devenv\r\nversion](https://github.com/elastic/serverless-gitops/blob/79862d97b1b1d3a97c0d8e2091ea06b9aed43f0c/services/kibana/versions.yaml#L4).\r\n\r\nThis change addresses the changes needed for this new pipeline taking\r\nunder consideration the environmental variable\r\n`KIBANA_MKI_QUALITY_GATE_MONITORING` which if present, it defines that\r\nwe do run the set of tests for quality gate but with an override.","sha":"60915420114fe35db940df268660503c93adae52"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: dkirchan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of just quality gate for security, a monitoring pipeline has been introduced which acts like quality gate but is overriding the kibana image with the latest dev-devenv version.
This change addresses the changes needed for this new pipeline taking under consideration the environmental variable
KIBANA_MKI_QUALITY_GATE_MONITORINGwhich if present, it defines that we do run the set of tests for quality gate but with an override.