enable skipped timeline sourcerer tests #196827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgestc
added
backport:skip
lgestc
force-pushed
the
reenable_sourcerer_timeline_e2e
branch
from
260f978 to
7485f76
Compare
lgestc
added
the
Team:Threat Hunting:Investigations
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
lgestc
force-pushed
the
reenable_sourcerer_timeline_e2e
branch
from
7485f76 to
bb45646
Compare
lgestc
changed the title
I will:) |
lgestc
force-pushed
the
reenable_sourcerer_timeline_e2e
branch
from
bb45646 to
bade2eb
Compare
lgestc
force-pushed
the
reenable_sourcerer_timeline_e2e
branch
2 times, most recently
from
7df97c2 to
128d2da
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7226[✅] Security Solution Investigations - Cypress: 25/25 tests passed. |
and they all pass :) |
|
|
||
| createField(timelineRuntimeField); | ||
| cy.get(GET_TIMELINE_HEADER(timelineRuntimeField)).should('exist'); | ||
| createRuntimeFieldFromTimeline(timelineRuntimeField); |
There was a problem hiding this comment.
Sweet, will pull in your changes here: https://github.com/elastic/kibana/pull/195662/files#diff-57ff085e8c0983eb6cbfb4fa9565a8a72a77f6a6a7a230eb96cf64f17feb1166 😄
...but we should update the timeline code to actually properly re-request the new runtime field when the modal closes. I didn't make that change in my PR as I wanted to do it in a separate PR
lgestc
force-pushed
the
reenable_sourcerer_timeline_e2e
branch
from
128d2da to
84c41ac
Compare
PhilippeOberti
approved these changes
Oct 24, 2024
lgestc
force-pushed
the
reenable_sourcerer_timeline_e2e
branch
from
883d38c to
7b509f9
Compare
💚 Build Succeeded
Metrics [docs]
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables a test skipped earlier #173854
and #183104
Flaky test run: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7226