Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Revert "Convert 8.x to 8.16 in doc link service" #196781

Merged
merged 2 commits into from
Oct 18, 2024
Merged

[DOCS] Revert "Convert 8.x to 8.16 in doc link service" #196781

merged 2 commits into from
Oct 18, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 17, 2024

Reverts #192794

Relates to elastic/docs#3092, which creates the 8.x and 8.16 docs. For that reason, the work-around is no longer required.

@lcawl lcawl marked this pull request as ready for review October 17, 2024 23:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Oct 17, 2024
@lcawl lcawl requested a review from a team October 17, 2024 23:08
kilfoyle
kilfoyle approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐄

@lcawl lcawl requested a review from a team as a code owner October 18, 2024 17:18
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #11 / ObservabilityApp feature controls observability security feature controls "before all" hook in "observability security feature controls"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 91.5KB 91.4KB -17.0B
lists 144.0KB 143.9KB -17.0B
total -34.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 450.2KB 450.2KB -17.0B

History

@lcawl lcawl merged commit 545e85c into 8.x Oct 18, 2024
22 checks passed
@lcawl lcawl deleted the revert-192794-8x-doclinks branch October 18, 2024 20:14
@lcawl lcawl removed the v8.17.0 label Oct 18, 2024
lcawl added a commit to lcawl/kibana that referenced this pull request Oct 18, 2024
@lcawl
[DOCS] Revert "Convert 8.x to 8.16 in doc link service" (elastic#196781)
c03e85c
@lcawl lcawl mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcawl @elasticmachine @kilfoyle