[Security Solution] Removes outdated rule tour for rule management workflow #196731
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplumlee
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
banderror
approved these changes
Oct 21, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @dplumlee |
|
Starting backport for target branches: 8.16 https://github.com/elastic/kibana/actions/runs/11442445390 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dplumlee
added a commit
to dplumlee/kibana
that referenced
this pull request
Oct 21, 2024
…rkflow (elastic#196731) ## Summary Removes the tour for rule features implemented in elastic#176767 as they are no longer new. Keeps the component and logic to use for future tours, just removes reference to the specific rules management tour. ### Steps to test 1. Make sure the `securitySolution.rulesManagementPage.newFeaturesTour.v8.13` local storage key is cleared from your kibana page (this will make the tour show up normally) 2. Notice that navigating to the rule management page does not display the rule tour Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 3547e15) # Conflicts: # x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/pages/rule_management/index.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dplumlee
added a commit
to dplumlee/kibana
that referenced
this pull request
Oct 21, 2024
…rkflow (elastic#196731) ## Summary Removes the tour for rule features implemented in elastic#176767 as they are no longer new. Keeps the component and logic to use for future tours, just removes reference to the specific rules management tour. ### Steps to test 1. Make sure the `securitySolution.rulesManagementPage.newFeaturesTour.v8.13` local storage key is cleared from your kibana page (this will make the tour show up normally) 2. Notice that navigating to the rule management page does not display the rule tour Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 3547e15) # Conflicts: # x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/pages/rule_management/index.tsx
dplumlee
added a commit
that referenced
this pull request
Oct 21, 2024
…ment workflow (#196731) (#197080) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] Removes outdated rule tour for rule management workflow (#196731)](#196731) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T14:33:26Z","message":"[Security Solution] Removes outdated rule tour for rule management workflow (#196731)\n\n## Summary\r\n\r\nRemoves the tour for rule features implemented in\r\nhttps://github.com//pull/176767 as they are no longer new.\r\nKeeps the component and logic to use for future tours, just removes\r\nreference to the specific rules management tour.\r\n\r\n### Steps to test\r\n\r\n1. Make sure the\r\n`securitySolution.rulesManagementPage.newFeaturesTour.v8.13` local\r\nstorage key is cleared from your kibana page (this will make the tour\r\nshow up normally)\r\n2. Notice that navigating to the rule management page does not display\r\nthe rule tour\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3547e154b57adbdbf36abda5c4571452b4ee0b26","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","v8.16.0","backport:version"],"number":196731,"url":"https://github.com/elastic/kibana/pull/196731","mergeCommit":{"message":"[Security Solution] Removes outdated rule tour for rule management workflow (#196731)\n\n## Summary\r\n\r\nRemoves the tour for rule features implemented in\r\nhttps://github.com//pull/176767 as they are no longer new.\r\nKeeps the component and logic to use for future tours, just removes\r\nreference to the specific rules management tour.\r\n\r\n### Steps to test\r\n\r\n1. Make sure the\r\n`securitySolution.rulesManagementPage.newFeaturesTour.v8.13` local\r\nstorage key is cleared from your kibana page (this will make the tour\r\nshow up normally)\r\n2. Notice that navigating to the rule management page does not display\r\nthe rule tour\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3547e154b57adbdbf36abda5c4571452b4ee0b26"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196731","number":196731,"mergeCommit":{"message":"[Security Solution] Removes outdated rule tour for rule management workflow (#196731)\n\n## Summary\r\n\r\nRemoves the tour for rule features implemented in\r\nhttps://github.com//pull/176767 as they are no longer new.\r\nKeeps the component and logic to use for future tours, just removes\r\nreference to the specific rules management tour.\r\n\r\n### Steps to test\r\n\r\n1. Make sure the\r\n`securitySolution.rulesManagementPage.newFeaturesTour.v8.13` local\r\nstorage key is cleared from your kibana page (this will make the tour\r\nshow up normally)\r\n2. Notice that navigating to the rule management page does not display\r\nthe rule tour\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3547e154b57adbdbf36abda5c4571452b4ee0b26"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
dplumlee
added a commit
that referenced
this pull request
Oct 21, 2024
…ent workflow (#196731) (#197086) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Removes outdated rule tour for rule management workflow (#196731)](#196731) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T14:33:26Z","message":"[Security Solution] Removes outdated rule tour for rule management workflow (#196731)\n\n## Summary\r\n\r\nRemoves the tour for rule features implemented in\r\nhttps://github.com//pull/176767 as they are no longer new.\r\nKeeps the component and logic to use for future tours, just removes\r\nreference to the specific rules management tour.\r\n\r\n### Steps to test\r\n\r\n1. Make sure the\r\n`securitySolution.rulesManagementPage.newFeaturesTour.v8.13` local\r\nstorage key is cleared from your kibana page (this will make the tour\r\nshow up normally)\r\n2. Notice that navigating to the rule management page does not display\r\nthe rule tour\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3547e154b57adbdbf36abda5c4571452b4ee0b26","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","v8.16.0","backport:version"],"number":196731,"url":"https://github.com/elastic/kibana/pull/196731","mergeCommit":{"message":"[Security Solution] Removes outdated rule tour for rule management workflow (#196731)\n\n## Summary\r\n\r\nRemoves the tour for rule features implemented in\r\nhttps://github.com//pull/176767 as they are no longer new.\r\nKeeps the component and logic to use for future tours, just removes\r\nreference to the specific rules management tour.\r\n\r\n### Steps to test\r\n\r\n1. Make sure the\r\n`securitySolution.rulesManagementPage.newFeaturesTour.v8.13` local\r\nstorage key is cleared from your kibana page (this will make the tour\r\nshow up normally)\r\n2. Notice that navigating to the rule management page does not display\r\nthe rule tour\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3547e154b57adbdbf36abda5c4571452b4ee0b26"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196731","number":196731,"mergeCommit":{"message":"[Security Solution] Removes outdated rule tour for rule management workflow (#196731)\n\n## Summary\r\n\r\nRemoves the tour for rule features implemented in\r\nhttps://github.com//pull/176767 as they are no longer new.\r\nKeeps the component and logic to use for future tours, just removes\r\nreference to the specific rules management tour.\r\n\r\n### Steps to test\r\n\r\n1. Make sure the\r\n`securitySolution.rulesManagementPage.newFeaturesTour.v8.13` local\r\nstorage key is cleared from your kibana page (this will make the tour\r\nshow up normally)\r\n2. Notice that navigating to the rule management page does not display\r\nthe rule tour\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3547e154b57adbdbf36abda5c4571452b4ee0b26"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197080","number":197080,"state":"OPEN"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the tour for rule features implemented in #176767 as they are no longer new. Keeps the component and logic to use for future tours, just removes reference to the specific rules management tour.
Steps to test
securitySolution.rulesManagementPage.newFeaturesTour.v8.13local storage key is cleared from your kibana page (this will make the tour show up normally)