Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Onboarding ux improvements #196726

Merged
merged 12 commits into from
Oct 18, 2024
Merged

[Search] Onboarding ux improvements #196726

merged 12 commits into from
Oct 18, 2024

Conversation

yansavitski
Copy link
Contributor

@yansavitski yansavitski commented Oct 17, 2024 •
edited by kibanamachine
Loading

Acceptance Criteria

  • Update Use in Playground to be a filled button and labelled “Search in Playground” (not empty button)
  • Include View in Discover as a default button in page header
  • Hide 'Add reference' in context menu when documents not presented in index to avoid duplication of this button
  • Add Spacer in settings
image image

@yansavitski yansavitski added release_note:fix backport:skip This commit does not require backporting Team:Search v8.16.0 labels Oct 17, 2024
@yansavitski yansavitski requested a review from a team as a code owner October 17, 2024 15:22
@yansavitski yansavitski changed the title Onboarding ux improvements [Search] Onboarding ux improvements Oct 17, 2024
@yansavitski yansavitski enabled auto-merge (squash) October 18, 2024 15:30
@yansavitski yansavitski merged commit 01d32b0 into elastic:main Oct 18, 2024
23 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #81 / Fleet Endpoints Integrations inputs_with_standalone_docker_agent generate a valid config for standalone agents

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchIndices 223 224 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchIndices 158.2KB 158.0KB -268.0B

History

@yansavitski yansavitski deleted the onboarding-ux-improvements branch October 18, 2024 16:34
@joemcelroy joemcelroy added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 18, 2024
@joemcelroy joemcelroy added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Oct 18, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11407573244

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11407573292

@kibanamachine kibanamachine mentioned this pull request Oct 18, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
@yansavitski
[Search] Onboarding ux improvements (elastic#196726)
24baae3 
Acceptance Criteria

- [x] Update Use in Playground to be a filled button and labelled
“Search in Playground” (not empty button)
- [x] Include View in Discover as a default button in page header
- [x] Hide 'Add reference' in context menu when documents not presented
in index to avoid duplication of this button
- [x] Add Spacer in settings

<img width="1212" alt="image"
src="https://github.com/user-attachments/assets/bcdfca68-b30f-4597-9e80-b0f27fcf6c9b">
<img width="1212" alt="image"
src="https://github.com/user-attachments/assets/48d78874-806f-4ba1-bca6-ba5516e4fcfa">

(cherry picked from commit 01d32b0)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 196726

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 196726

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 18, 2024
@kibanamachine @yansavitski
[8.x] [Search] Onboarding ux improvements (#196726) (#196927)
17ddf8d 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] Onboarding ux improvements
(#196726)](#196726)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yan
Savitski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T16:32:33Z","message":"[Search]
Onboarding ux improvements (#196726)\n\nAcceptance Criteria\r\n\r\n- [x]
Update Use in Playground to be a filled button and labelled\r\n“Search
in Playground” (not empty button)\r\n- [x] Include View in Discover as a
default button in page header\r\n- [x] Hide 'Add reference' in context
menu when documents not presented\r\nin index to avoid duplication of
this button\r\n- [x] Add Spacer in settings\r\n\r\n<img width=\"1212\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bcdfca68-b30f-4597-9e80-b0f27fcf6c9b\">\r\n<img
width=\"1212\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/48d78874-806f-4ba1-bca6-ba5516e4fcfa\">","sha":"01d32b0dc0f377d8608a4b63c455b4982b1f33d3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","v8.16.0"],"title":"[Search]
Onboarding ux
improvements","number":196726,"url":"https://github.com/elastic/kibana/pull/196726","mergeCommit":{"message":"[Search]
Onboarding ux improvements (#196726)\n\nAcceptance Criteria\r\n\r\n- [x]
Update Use in Playground to be a filled button and labelled\r\n“Search
in Playground” (not empty button)\r\n- [x] Include View in Discover as a
default button in page header\r\n- [x] Hide 'Add reference' in context
menu when documents not presented\r\nin index to avoid duplication of
this button\r\n- [x] Add Spacer in settings\r\n\r\n<img width=\"1212\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bcdfca68-b30f-4597-9e80-b0f27fcf6c9b\">\r\n<img
width=\"1212\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/48d78874-806f-4ba1-bca6-ba5516e4fcfa\">","sha":"01d32b0dc0f377d8608a4b63c455b4982b1f33d3"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196726","number":196726,"mergeCommit":{"message":"[Search]
Onboarding ux improvements (#196726)\n\nAcceptance Criteria\r\n\r\n- [x]
Update Use in Playground to be a filled button and labelled\r\n“Search
in Playground” (not empty button)\r\n- [x] Include View in Discover as a
default button in page header\r\n- [x] Hide 'Add reference' in context
menu when documents not presented\r\nin index to avoid duplication of
this button\r\n- [x] Add Spacer in settings\r\n\r\n<img width=\"1212\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bcdfca68-b30f-4597-9e80-b0f27fcf6c9b\">\r\n<img
width=\"1212\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/48d78874-806f-4ba1-bca6-ba5516e4fcfa\">","sha":"01d32b0dc0f377d8608a4b63c455b4982b1f33d3"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Yan Savitski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yansavitski @elasticmachine @kibanamachine @joemcelroy