Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: pull_request in forked PRs cannot change permissions scope #196550

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 16, 2024

Summary

Fixes

image

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@v1v v1v added the release_note:skip Skip the PR/issue when compiling release notes label Oct 16, 2024
@v1v v1v requested a review from a team October 16, 2024 14:04
@v1v v1v self-assigned this Oct 16, 2024
@v1v v1v requested a review from a team as a code owner October 16, 2024 14:04
@v1v v1v enabled auto-merge (squash) October 16, 2024 19:30
@reakaleek
Copy link
Member

reakaleek commented Oct 16, 2024

@v1v this needs a backport.

Not sure which versions. Here a failing example for 8.14 #196218

@v1v v1v added the backport:all-open Backport to all branches that could still receive a release label Oct 16, 2024
@v1v v1v merged commit 4b09db3 into elastic:main Oct 17, 2024
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 7.17, 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11376711646

@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 196550

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 17, 2024
…ssions scope (#196550) (#196622)

# Backport

This will backport the following commits from `main` to `8.15`:
- [github-actions: pull_request in forked PRs cannot change permissions
scope (#196550)](#196550)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Victor
Martinez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T01:33:19Z","message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open"],"title":"github-actions:
pull_request in forked PRs cannot change permissions
scope","number":196550,"url":"https://github.com/elastic/kibana/pull/196550","mergeCommit":{"message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196550","number":196550,"mergeCommit":{"message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88"}}]}]
BACKPORT-->

Co-authored-by: Victor Martinez <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 17, 2024
…sions scope (#196550) (#196623)

# Backport

This will backport the following commits from `main` to `8.x`:
- [github-actions: pull_request in forked PRs cannot change permissions
scope (#196550)](#196550)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Victor
Martinez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T01:33:19Z","message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open"],"title":"github-actions:
pull_request in forked PRs cannot change permissions
scope","number":196550,"url":"https://github.com/elastic/kibana/pull/196550","mergeCommit":{"message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196550","number":196550,"mergeCommit":{"message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88"}}]}]
BACKPORT-->

Co-authored-by: Victor Martinez <[email protected]>
@v1v v1v added backport:version Backport to applied version labels v8.1.4 v8.14.4 labels Oct 17, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 7.17, 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11380104963

@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15 Cherrypick failed because the selected commit (4b09db3) is empty. It looks like the commit was already backported in #196622
8.16
8.x Cherrypick failed because the selected commit (4b09db3) is empty. It looks like the commit was already backported in #196623

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 196550

Questions ?

Please refer to the Backport tool documentation

@v1v
Copy link
Member Author

v1v commented Oct 17, 2024

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

v1v added a commit to v1v/kibana that referenced this pull request Oct 17, 2024
kibanamachine added a commit that referenced this pull request Oct 17, 2024
…ssions scope (#196550) (#196631)

# Backport

This will backport the following commits from `main` to `8.16`:
- [github-actions: pull_request in forked PRs cannot change permissions
scope (#196550)](#196550)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Victor
Martinez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T01:33:19Z","message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.1.4","backport:all-open","v8.16.0","v8.14.4","backport:version","v8.15.3"],"title":"github-actions:
pull_request in forked PRs cannot change permissions
scope","number":196550,"url":"https://github.com/elastic/kibana/pull/196550","mergeCommit":{"message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88"}},"sourceBranch":"main","suggestedTargetBranches":["8.1","8.14"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196550","number":196550,"mergeCommit":{"message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88"}},{"branch":"8.1","label":"v8.1.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196623","number":196623,"state":"MERGED","mergeCommit":{"sha":"e0cbcd6239de174da6632895568594e1732cb206","message":"[8.x]
github-actions: pull_request in forked PRs cannot change permissions
scope (#196550) (#196623)\n\n# Backport\n\nThis will backport the
following commits from `main` to `8.x`:\n- [github-actions: pull_request
in forked PRs cannot change permissions\nscope
(#196550)](https://github.com/elastic/kibana/pull/196550)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Victor\nMartinez\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-17T01:33:19Z\",\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:all-open\"],\"title\":\"github-actions:\npull_request
in forked PRs cannot change
permissions\nscope\",\"number\":196550,\"url\":\"https://github.com/elastic/kibana/pull/196550\",\"mergeCommit\":{\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196550\",\"number\":196550,\"mergeCommit\":{\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Victor Martinez
<[email protected]>"}},{"branch":"8.14","label":"v8.14.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196622","number":196622,"state":"MERGED","mergeCommit":{"sha":"78986c3f6c87dd04136b1ecd9e2c3d2366da9979","message":"[8.15]
github-actions: pull_request in forked PRs cannot change permissions
scope (#196550) (#196622)\n\n# Backport\n\nThis will backport the
following commits from `main` to `8.15`:\n- [github-actions:
pull_request in forked PRs cannot change permissions\nscope
(#196550)](https://github.com/elastic/kibana/pull/196550)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Victor\nMartinez\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-17T01:33:19Z\",\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:all-open\"],\"title\":\"github-actions:\npull_request
in forked PRs cannot change
permissions\nscope\",\"number\":196550,\"url\":\"https://github.com/elastic/kibana/pull/196550\",\"mergeCommit\":{\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196550\",\"number\":196550,\"mergeCommit\":{\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Victor Martinez <[email protected]>"}}]}] BACKPORT-->

Co-authored-by: Victor Martinez <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 18, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Ikuni17 pushed a commit that referenced this pull request Oct 18, 2024
…ssions scope (#196550) (#196632)

# Backport

This will backport the following commits from `main` to `8.14`:
- [github-actions: pull_request in forked PRs cannot change permissions
scope (#196550)](#196550)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Victor
Martinez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T01:33:19Z","message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.1.4","backport:all-open","v8.16.0","v8.14.4","backport:version","v8.15.3"],"number":196550,"url":"https://github.com/elastic/kibana/pull/196550","mergeCommit":{"message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88"}},"sourceBranch":"main","suggestedTargetBranches":["8.1","8.14"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196550","number":196550,"mergeCommit":{"message":"github-actions:
pull_request in forked PRs cannot change permissions scope
(#196550)","sha":"4b09db32f4da6e02068c7888d1888242129eec88"}},{"branch":"8.1","label":"v8.1.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196623","number":196623,"state":"MERGED","mergeCommit":{"sha":"e0cbcd6239de174da6632895568594e1732cb206","message":"[8.x]
github-actions: pull_request in forked PRs cannot change permissions
scope (#196550) (#196623)\n\n# Backport\n\nThis will backport the
following commits from `main` to `8.x`:\n- [github-actions: pull_request
in forked PRs cannot change permissions\nscope
(#196550)](https://github.com/elastic/kibana/pull/196550)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Victor\nMartinez\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-17T01:33:19Z\",\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:all-open\"],\"title\":\"github-actions:\npull_request
in forked PRs cannot change
permissions\nscope\",\"number\":196550,\"url\":\"https://github.com/elastic/kibana/pull/196550\",\"mergeCommit\":{\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196550\",\"number\":196550,\"mergeCommit\":{\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Victor Martinez
<[email protected]>"}},{"branch":"8.14","label":"v8.14.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196622","number":196622,"state":"MERGED","mergeCommit":{"sha":"78986c3f6c87dd04136b1ecd9e2c3d2366da9979","message":"[8.15]
github-actions: pull_request in forked PRs cannot change permissions
scope (#196550) (#196622)\n\n# Backport\n\nThis will backport the
following commits from `main` to `8.15`:\n- [github-actions:
pull_request in forked PRs cannot change permissions\nscope
(#196550)](https://github.com/elastic/kibana/pull/196550)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Victor\nMartinez\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-17T01:33:19Z\",\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:all-open\"],\"title\":\"github-actions:\npull_request
in forked PRs cannot change
permissions\nscope\",\"number\":196550,\"url\":\"https://github.com/elastic/kibana/pull/196550\",\"mergeCommit\":{\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196550\",\"number\":196550,\"mergeCommit\":{\"message\":\"github-actions:\npull_request
in forked PRs cannot change permissions
scope\n(#196550)\",\"sha\":\"4b09db32f4da6e02068c7888d1888242129eec88\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Victor Martinez
<[email protected]>"}},{"url":"https://github.com/elastic/kibana/pull/196631","number":196631,"branch":"8.16","state":"OPEN"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.1.4 v8.14.4 v8.15.3 v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants