Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Remove exceptions_list, author and license from Diffable Rule #196396

Closed
wants to merge 17 commits into from

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Oct 15, 2024

Resolves: #196213

Summary

Excludes the fields exceptions_list, author and license from the DiffableRule definition.

This will:

  • prevent them from appearing in the Three Way Diff component
  • prevent them from being able to be passed as a value in the fields object of the /upgrade/_perform endpoint to set a specific pick_version for it (NOTE: the current logic already forces exceptions_list to upgrade to the CURRENT version, but removing it from DiffableRule, will completely remove the from the payload schema, and the endpoint will then throw a validation error if included, rather than silently ignoring it)

For maintainers

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 15, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@jpdjere jpdjere self-assigned this Oct 15, 2024
@jpdjere jpdjere added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v9.0.0 v8.16.0 labels Oct 15, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 15, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / edit package policy page modify agent policies should create agent policy with sys monitoring when new agent policy button is clicked
  • [job] [logs] Jest Tests #10 / edit package policy page modify agent policies should not remove managed policy when policies are modified
  • [job] [logs] Jest Tests #10 / edit package policy page should disable submit button on invalid form with empty package var
  • [job] [logs] Jest Tests #10 / edit package policy page should navigate on submit
  • [job] [logs] Jest Tests #10 / edit package policy page should show generic error on other statusCode on submit
  • [job] [logs] Jest Tests #10 / edit package policy page should show out of date error on 409 statusCode on submit
  • [job] [logs] FTR Configs #42 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Perform Prebuilt Rules Upgrades - mode: ALL_RULES successful updates upgrades all upgreadeable rules fields to their MERGED versions
  • [job] [logs] FTR Configs #79 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Perform Prebuilt Rules Upgrades - mode: ALL_RULES successful updates upgrades all upgreadeable rules fields to their MERGED versions
  • [job] [logs] FTR Configs #42 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Perform Prebuilt Rules Upgrades - mode: ALL_RULES successful updates upgrades all upgreadeable rules fields to their MERGED versions
  • [job] [logs] FTR Configs #79 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Perform Prebuilt Rules Upgrades - mode: ALL_RULES successful updates upgrades all upgreadeable rules fields to their MERGED versions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.8MB 20.8MB +500.0B

History

cc @jpdjere

@jpdjere
Copy link
Contributor Author

jpdjere commented Oct 16, 2024

Closing in favour of: #196561

1 similar comment
@jpdjere
Copy link
Contributor Author

jpdjere commented Oct 16, 2024

Closing in favour of: #196561

@jpdjere jpdjere closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Remove exceptions_list, author and license from Diffable Rule
3 participants