[Lens] Fix switchVisualizationType to use it without layerId #196295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
mbondyra
force-pushed
the
lens/fix_suggestions_api
branch
from
41a6664
to
6afce77
Compare
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
stratoula
added
backport:prev-minor
markov00
approved these changes
Oct 15, 2024
mbondyra
force-pushed
the
lens/fix_suggestions_api
branch
from
6afce77
to
948b99e
Compare
Co-authored-by: Marco Vettorello <[email protected]>
mbondyra
force-pushed
the
lens/fix_suggestions_api
branch
from
77abd20
to
0ac6c5c
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11354960986 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
…#196295) With [PR elastic#187475](https://github.com/elastic/kibana/pull/187475/files) we introduced a bug, affecting the AI assistant's suggestions API when switching between different chart types (e.g., from bar to line chart). This feature relies on the switchVisualizationType method, which was changed to require a `layerId`. However, the suggestions API does not provide `layerId`, causing the chart type to not switch as expected. Solution: The bug can be resolved by modifying the logic in the `switchVisualizationType` method. We changed: ```ts const dataLayer = state.layers.find((l) => l.layerId === layerId); ``` to: ```ts const dataLayer = state.layers.find((l) => l.layerId === layerId) ?? state.layers[0]; ``` This ensures that the suggestions API falls back to the first layer if no specific layerId is provided. --------- Co-authored-by: Marco Vettorello <[email protected]> (cherry picked from commit e476220)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
…196295) (#196448) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens] Fix switchVisualizationType to use it without layerId (#196295)](#196295) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T21:53:00Z","message":"[Lens] Fix switchVisualizationType to use it without layerId (#196295)\n\nWith [PR #187475](https://github.com/elastic/kibana/pull/187475/files)\r\nwe introduced a bug, affecting the AI assistant's suggestions API when\r\nswitching between different chart types (e.g., from bar to line chart).\r\nThis feature relies on the switchVisualizationType method, which was\r\nchanged to require a `layerId`. However, the suggestions API does not\r\nprovide `layerId`, causing the chart type to not switch as expected.\r\n\r\nSolution:\r\nThe bug can be resolved by modifying the logic in the\r\n`switchVisualizationType` method. We changed:\r\n\r\n```ts\r\nconst dataLayer = state.layers.find((l) => l.layerId === layerId);\r\n```\r\n\r\nto:\r\n\r\n```ts\r\nconst dataLayer = state.layers.find((l) => l.layerId === layerId) ?? state.layers[0];\r\n```\r\n\r\nThis ensures that the suggestions API falls back to the first layer if\r\nno specific layerId is provided.\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Vettorello <[email protected]>","sha":"e4762201fdd84f372c78bc2a159061e504b26e78","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor"],"title":"[Lens] Fix switchVisualizationType to use it without layerId","number":196295,"url":"https://github.com/elastic/kibana/pull/196295","mergeCommit":{"message":"[Lens] Fix switchVisualizationType to use it without layerId (#196295)\n\nWith [PR #187475](https://github.com/elastic/kibana/pull/187475/files)\r\nwe introduced a bug, affecting the AI assistant's suggestions API when\r\nswitching between different chart types (e.g., from bar to line chart).\r\nThis feature relies on the switchVisualizationType method, which was\r\nchanged to require a `layerId`. However, the suggestions API does not\r\nprovide `layerId`, causing the chart type to not switch as expected.\r\n\r\nSolution:\r\nThe bug can be resolved by modifying the logic in the\r\n`switchVisualizationType` method. We changed:\r\n\r\n```ts\r\nconst dataLayer = state.layers.find((l) => l.layerId === layerId);\r\n```\r\n\r\nto:\r\n\r\n```ts\r\nconst dataLayer = state.layers.find((l) => l.layerId === layerId) ?? state.layers[0];\r\n```\r\n\r\nThis ensures that the suggestions API falls back to the first layer if\r\nno specific layerId is provided.\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Vettorello <[email protected]>","sha":"e4762201fdd84f372c78bc2a159061e504b26e78"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196295","number":196295,"mergeCommit":{"message":"[Lens] Fix switchVisualizationType to use it without layerId (#196295)\n\nWith [PR #187475](https://github.com/elastic/kibana/pull/187475/files)\r\nwe introduced a bug, affecting the AI assistant's suggestions API when\r\nswitching between different chart types (e.g., from bar to line chart).\r\nThis feature relies on the switchVisualizationType method, which was\r\nchanged to require a `layerId`. However, the suggestions API does not\r\nprovide `layerId`, causing the chart type to not switch as expected.\r\n\r\nSolution:\r\nThe bug can be resolved by modifying the logic in the\r\n`switchVisualizationType` method. We changed:\r\n\r\n```ts\r\nconst dataLayer = state.layers.find((l) => l.layerId === layerId);\r\n```\r\n\r\nto:\r\n\r\n```ts\r\nconst dataLayer = state.layers.find((l) => l.layerId === layerId) ?? state.layers[0];\r\n```\r\n\r\nThis ensures that the suggestions API falls back to the first layer if\r\nno specific layerId is provided.\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Vettorello <[email protected]>","sha":"e4762201fdd84f372c78bc2a159061e504b26e78"}}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR #187475 we introduced a bug, affecting the AI assistant's suggestions API when switching between different chart types (e.g., from bar to line chart). This feature relies on the switchVisualizationType method, which was changed to require a
layerId. However, the suggestions API does not providelayerId, causing the chart type to not switch as expected.Solution:
The bug can be resolved by modifying the logic in the
switchVisualizationTypemethod. We changed:to:
This ensures that the suggestions API falls back to the first layer if no specific layerId is provided.