Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] fix incomplete string escaping or encoding #196248

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Oct 15, 2024

Summary

Fixes incomplete string escaping or encoding for TSVB.

@mbondyra mbondyra added Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 15, 2024
@mbondyra mbondyra requested a review from a team as a code owner October 15, 2024 08:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra added backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 17, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #28 / InfraOps App Metrics UI Home page with metrics present Saved Views should update the current saved view and load it

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 506.9KB 507.0KB +32.0B

History

@mbondyra mbondyra merged commit 7c4a83d into elastic:main Oct 17, 2024
27 checks passed
@mbondyra mbondyra deleted the tsvb_fix_code_scanning_alerts_61-66 branch October 17, 2024 11:13
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11383781790

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
## Summary

Fixes incomplete string escaping or encoding for TSVB.

(cherry picked from commit 7c4a83d)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
## Summary

Fixes incomplete string escaping or encoding for TSVB.

(cherry picked from commit 7c4a83d)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
## Summary

Fixes incomplete string escaping or encoding for TSVB.

(cherry picked from commit 7c4a83d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 17, 2024
…196665)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[TSVB] fix incomplete string escaping or encoding
(#196248)](#196248)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T11:13:09Z","message":"[TSVB]
fix incomplete string escaping or encoding (#196248)\n\n##
Summary\r\n\r\nFixes incomplete string escaping or encoding for
TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","release_note:fix","Team:Visualizations","v9.0.0","backport:prev-major","v8.17.0"],"title":"[TSVB]
fix incomplete string escaping or
encoding","number":196248,"url":"https://github.com/elastic/kibana/pull/196248","mergeCommit":{"message":"[TSVB]
fix incomplete string escaping or encoding (#196248)\n\n##
Summary\r\n\r\nFixes incomplete string escaping or encoding for
TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196248","number":196248,"mergeCommit":{"message":"[TSVB]
fix incomplete string escaping or encoding (#196248)\n\n##
Summary\r\n\r\nFixes incomplete string escaping or encoding for
TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 17, 2024
…96668)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[TSVB] fix incomplete string escaping or encoding
(#196248)](#196248)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T11:13:09Z","message":"[TSVB]
fix incomplete string escaping or encoding (#196248)\n\n##
Summary\r\n\r\nFixes incomplete string escaping or encoding for
TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","release_note:fix","Team:Visualizations","v9.0.0","backport:prev-major","v8.17.0"],"title":"[TSVB]
fix incomplete string escaping or
encoding","number":196248,"url":"https://github.com/elastic/kibana/pull/196248","mergeCommit":{"message":"[TSVB]
fix incomplete string escaping or encoding (#196248)\n\n##
Summary\r\n\r\nFixes incomplete string escaping or encoding for
TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196248","number":196248,"mergeCommit":{"message":"[TSVB]
fix incomplete string escaping or encoding (#196248)\n\n##
Summary\r\n\r\nFixes incomplete string escaping or encoding for
TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <[email protected]>
@mistic
Copy link
Member

mistic commented Oct 17, 2024

This PR didn't make it into the latest BC of v8.15.3. Updating the labels.

@mistic mistic added v8.15.4 and removed v8.15.3 labels Oct 17, 2024
kibanamachine added a commit that referenced this pull request Oct 18, 2024
…196666)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[TSVB] fix incomplete string escaping or encoding
(#196248)](#196248)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T11:13:09Z","message":"[TSVB]
fix incomplete string escaping or encoding (#196248)\n\n##
Summary\r\n\r\nFixes incomplete string escaping or encoding for
TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","release_note:fix","Team:Visualizations","v9.0.0","backport:prev-major","v8.17.0"],"title":"[TSVB]
fix incomplete string escaping or
encoding","number":196248,"url":"https://github.com/elastic/kibana/pull/196248","mergeCommit":{"message":"[TSVB]
fix incomplete string escaping or encoding (#196248)\n\n##
Summary\r\n\r\nFixes incomplete string escaping or encoding for
TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196248","number":196248,"mergeCommit":{"message":"[TSVB]
fix incomplete string escaping or encoding (#196248)\n\n##
Summary\r\n\r\nFixes incomplete string escaping or encoding for
TSVB.","sha":"7c4a83d4c920b5bc35b88ffc0460c139bb0d846b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.15.4 v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants