[ES|QL] More AST mutation APIs #196240
Merged
[ES|QL] More AST mutation APIs #196240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
vadimkibana
added
review
release_note:skip
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Oct 15, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11349628924 |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
## Summary Partially addresses elastic#191812 Implements the following high-level ES|QL AST manipulation methods: - `.generic` - `.appendCommandArgument()` — Add a new main command argument to a command. - `.removeCommandArgument()` — Remove a command argument from the AST. - `.commands` - `.from` - `.sources` - `.list()` — List all `FROM` sources. - `.find()` — Find a source by name. - `.remove()` — Remove a source by name. - `.insert()` — Insert a source. - `.upsert()` — Insert a source, if it does not exist. - `.limit` - `.list()` — List all `LIMIT` commands. - `.byIndex()` — Find a `LIMIT` command by index. - `.find()` — Find a `LIMIT` command by a predicate function. - `.remove()` — Remove a `LIMIT` command by index. - `.set()` — Set the limit value of a specific `LIMIT` command. - `.upsert()` — Insert a `LIMIT` command, or update the limit value if it already exists. ### Checklist Delete any items that are not applicable to this PR. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) (cherry picked from commit 10364fb)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] More AST mutation APIs (#196240)](#196240) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vadim Kibana","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T15:45:03Z","message":"[ES|QL] More AST mutation APIs (#196240)\n\n## Summary\r\n\r\nPartially addresses https://github.com/elastic/kibana/issues/191812\r\n\r\nImplements the following high-level ES|QL AST manipulation methods:\r\n\r\n\r\n- `.generic`\r\n- `.appendCommandArgument()` — Add a new main command argument to\r\na command.\r\n- `.removeCommandArgument()` — Remove a command argument from the\r\nAST.\r\n- `.commands`\r\n - `.from`\r\n - `.sources`\r\n - `.list()` — List all `FROM` sources.\r\n - `.find()` — Find a source by name.\r\n - `.remove()` — Remove a source by name.\r\n - `.insert()` — Insert a source.\r\n - `.upsert()` — Insert a source, if it does not exist.\r\n - `.limit`\r\n - `.list()` — List all `LIMIT` commands.\r\n - `.byIndex()` — Find a `LIMIT` command by index.\r\n - `.find()` — Find a `LIMIT` command by a predicate function.\r\n - `.remove()` — Remove a `LIMIT` command by index.\r\n- `.set()` — Set the limit value of a specific `LIMIT` command.\r\n- `.upsert()` — Insert a `LIMIT` command, or update the limit\r\nvalue if it already exists.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"10364fba2db8bb2080a97173c76a9d1aef1e80ed","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL] More AST mutation APIs","number":196240,"url":"https://github.com/elastic/kibana/pull/196240","mergeCommit":{"message":"[ES|QL] More AST mutation APIs (#196240)\n\n## Summary\r\n\r\nPartially addresses https://github.com/elastic/kibana/issues/191812\r\n\r\nImplements the following high-level ES|QL AST manipulation methods:\r\n\r\n\r\n- `.generic`\r\n- `.appendCommandArgument()` — Add a new main command argument to\r\na command.\r\n- `.removeCommandArgument()` — Remove a command argument from the\r\nAST.\r\n- `.commands`\r\n - `.from`\r\n - `.sources`\r\n - `.list()` — List all `FROM` sources.\r\n - `.find()` — Find a source by name.\r\n - `.remove()` — Remove a source by name.\r\n - `.insert()` — Insert a source.\r\n - `.upsert()` — Insert a source, if it does not exist.\r\n - `.limit`\r\n - `.list()` — List all `LIMIT` commands.\r\n - `.byIndex()` — Find a `LIMIT` command by index.\r\n - `.find()` — Find a `LIMIT` command by a predicate function.\r\n - `.remove()` — Remove a `LIMIT` command by index.\r\n- `.set()` — Set the limit value of a specific `LIMIT` command.\r\n- `.upsert()` — Insert a `LIMIT` command, or update the limit\r\nvalue if it already exists.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"10364fba2db8bb2080a97173c76a9d1aef1e80ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196240","number":196240,"mergeCommit":{"message":"[ES|QL] More AST mutation APIs (#196240)\n\n## Summary\r\n\r\nPartially addresses https://github.com/elastic/kibana/issues/191812\r\n\r\nImplements the following high-level ES|QL AST manipulation methods:\r\n\r\n\r\n- `.generic`\r\n- `.appendCommandArgument()` — Add a new main command argument to\r\na command.\r\n- `.removeCommandArgument()` — Remove a command argument from the\r\nAST.\r\n- `.commands`\r\n - `.from`\r\n - `.sources`\r\n - `.list()` — List all `FROM` sources.\r\n - `.find()` — Find a source by name.\r\n - `.remove()` — Remove a source by name.\r\n - `.insert()` — Insert a source.\r\n - `.upsert()` — Insert a source, if it does not exist.\r\n - `.limit`\r\n - `.list()` — List all `LIMIT` commands.\r\n - `.byIndex()` — Find a `LIMIT` command by index.\r\n - `.find()` — Find a `LIMIT` command by a predicate function.\r\n - `.remove()` — Remove a `LIMIT` command by index.\r\n- `.set()` — Set the limit value of a specific `LIMIT` command.\r\n- `.upsert()` — Insert a `LIMIT` command, or update the limit\r\nvalue if it already exists.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"10364fba2db8bb2080a97173c76a9d1aef1e80ed"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Vadim Kibana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #191812
Implements the following high-level ES|QL AST manipulation methods:
.generic.appendCommandArgument()— Add a new main command argument to a command..removeCommandArgument()— Remove a command argument from the AST..commands.from.sources.list()— List allFROMsources..find()— Find a source by name..remove()— Remove a source by name..insert()— Insert a source..upsert()— Insert a source, if it does not exist..limit.list()— List allLIMITcommands..byIndex()— Find aLIMITcommand by index..find()— Find aLIMITcommand by a predicate function..remove()— Remove aLIMITcommand by index..set()— Set the limit value of a specificLIMITcommand..upsert()— Insert aLIMITcommand, or update the limit value if it already exists.Checklist
Delete any items that are not applicable to this PR.
For maintainers