Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transform: Fix <DefinePivotSummary /> jest test. #195998

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[ML] Transform: Fix <DefinePivotSummary /> jest test. #195998

merged 3 commits into from
Dec 5, 2024

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Oct 11, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #195992 (failing test).

Updates the mock for the preview endpoint to make the test pass again.

Checklist

@walterra walterra self-assigned this Oct 11, 2024
@walterra walterra mentioned this pull request Oct 11, 2024
Closed
@walterra walterra force-pushed the ml-transform-step-define-summary-test-fix branch from 7ab30e7 to 7b0e547 Compare December 2, 2024 12:26
@walterra walterra added v9.0.0 v8.18.0 :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms backport:version Backport to applied version labels labels Dec 2, 2024
@walterra walterra marked this pull request as ready for review December 2, 2024 12:30
@walterra walterra requested a review from a team as a code owner December 2, 2024 12:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra requested review from darnautov and rbrtj December 2, 2024 12:31
peteharverson
peteharverson approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rbrtj
rbrtj approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@rbrtj rbrtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @walterra

@walterra walterra merged commit c4d6403 into elastic:main Dec 5, 2024
8 checks passed
@walterra walterra deleted the ml-transform-step-define-summary-test-fix branch December 5, 2024 15:59
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12183422702

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 5, 2024
@walterra
[ML] Transform: Fix <DefinePivotSummary /> jest test. (elastic#195998)
c65b935 
## Summary

Fixes elastic#195992 (failing test).

Updates the mock for the preview endpoint to make the test pass again.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)

(cherry picked from commit c4d6403)
@kibanamachine kibanamachine mentioned this pull request Dec 5, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 5, 2024
@kibanamachine @walterra
[8.x] [ML] Transform: Fix &lt;DefinePivotSummary /&gt; jest test. (#1…
627d84b 
…95998) (#203129)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Transform: Fix &lt;DefinePivotSummary /&gt; jest test.
(#195998)](#195998)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Walter
Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T15:59:00Z","message":"[ML]
Transform: Fix <DefinePivotSummary /> jest test. (#195998)\n\n##
Summary\r\n\r\nFixes #195992 (failing test).\r\n\r\nUpdates the mock for
the preview endpoint to make the test pass again.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"c4d64039b3c23433eb643f3a772357407695d024","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:Transforms","v9.0.0","backport:version","v8.18.0"],"title":"[ML]
Transform: Fix <DefinePivotSummary /> jest
test.","number":195998,"url":"https://github.com/elastic/kibana/pull/195998","mergeCommit":{"message":"[ML]
Transform: Fix <DefinePivotSummary /> jest test. (#195998)\n\n##
Summary\r\n\r\nFixes #195992 (failing test).\r\n\r\nUpdates the mock for
the preview endpoint to make the test pass again.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"c4d64039b3c23433eb643f3a772357407695d024"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195998","number":195998,"mergeCommit":{"message":"[ML]
Transform: Fix <DefinePivotSummary /> jest test. (#195998)\n\n##
Summary\r\n\r\nFixes #195992 (failing test).\r\n\r\nUpdates the mock for
the preview endpoint to make the test pass again.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"c4d64039b3c23433eb643f3a772357407695d024"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Walter Rafelsberger <[email protected]>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@walterra @SoniaSanzV
[ML] Transform: Fix <DefinePivotSummary /> jest test. (elastic#195998)
daec1ef 
## Summary

Fixes elastic#195992 (failing test).

Updates the mock for the preview endpoint to make the test pass again.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@walterra @SoniaSanzV
[ML] Transform: Fix <DefinePivotSummary /> jest test. (elastic#195998)
b36baeb 
## Summary

Fixes elastic#195992 (failing test).

Updates the mock for the preview endpoint to make the test pass again.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@walterra @CAWilson94
[ML] Transform: Fix <DefinePivotSummary /> jest test. (elastic#195998)
1bde52e 
## Summary

Fixes elastic#195992 (failing test).

Updates the mock for the preview endpoint to make the test pass again.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@walterra @Samiul-TheSoccerFan
[ML] Transform: Fix <DefinePivotSummary /> jest test. (elastic#195998)
c106f2c 
## Summary

Fixes elastic#195992 (failing test).

Updates the mock for the preview endpoint to make the test pass again.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
@walterra @mykolaharmash
[ML] Transform: Fix <DefinePivotSummary /> jest test. (elastic#195998)
96fc387 
## Summary

Fixes elastic#195992 (failing test).

Updates the mock for the preview endpoint to make the test pass again.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@walterra @CAWilson94
[ML] Transform: Fix <DefinePivotSummary /> jest test. (elastic#195998)
d16e2cc 
## Summary

Fixes elastic#195992 (failing test).

Updates the mock for the preview endpoint to make the test pass again.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbrtj rbrtj rbrtj approved these changes

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@walterra walterra

Labels
backport:version Backport to applied version labels Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
5 participants
@walterra @elasticmachine @kibanamachine @peteharverson @rbrtj