[Security Assistant] Delete legacy ESQL knowledge base docs #195996
Merged
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
patrykkopycinski
approved these changes
Oct 14, 2024
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11330122409 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…95996) (#196162) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Assistant] Delete legacy ESQL knowledge base docs (#195996)](#195996) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T14:59:27Z","message":"[Security Assistant] Delete legacy ESQL knowledge base docs (#195996)","sha":"71de0a768e6e96660275fa482ffd3643278a4117","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version"],"title":"[Security Assistant] Delete legacy ESQL knowledge base docs","number":195996,"url":"https://github.com/elastic/kibana/pull/195996","mergeCommit":{"message":"[Security Assistant] Delete legacy ESQL knowledge base docs (#195996)","sha":"71de0a768e6e96660275fa482ffd3643278a4117"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195996","number":195996,"mergeCommit":{"message":"[Security Assistant] Delete legacy ESQL knowledge base docs (#195996)","sha":"71de0a768e6e96660275fa482ffd3643278a4117"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the user clicks "Setup Knowledge Base" (must have
assistantKnowledgeBaseByDefault) feature flag enabled, we will delete any docs with the legacymetadata.kbResourceproperty with values ofesqlorunknownas these are ESQL docs we no longer use.To test
Add feature flag to dev yml:
Start with fresh es/kibana in 8.15 and go through the KB setup. Then checkout this branch. You should again be prompted to setup knowledge base when you open the assistant. Do it. Check your Kibana logs. You should see something like: