Updates file upload formats in Kibana guide #195880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosabogi
added
Team:Docs
release_note:skip
|
Pinging @elastic/kibana-docs (Team:Docs) |
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
leemthompo
reviewed
Oct 11, 2024
Comment on lines
83
to
84
| - CSV | ||
|
|
There was a problem hiding this comment.
Nit: don't need spaces in between and should use * instead of - for consistency :)
There was a problem hiding this comment.
Thanks for the review! I fixed the formatting issue in a new commit.
The UI hasn't changed so far, so I think we can't update the screenshot here:
I just pulled this from a serverless deployment where the changes are already live (it's probably live on 8.16.0 SNAPSHOT and definitely |
|
@kosabogi I see you updated in the other PR, the screenshots should be identical so you can replicate here :) |
leemthompo
approved these changes
Oct 11, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11324101019 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
### Overview This PR updates the **Upload a file** section in the **Add data** page to reflect the changes to the supported file formats in the Data Visualizer. ### Related issue: elastic/search-docs-team#189 (comment) ### Preview (cherry picked from commit 94ee8d5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Updates file upload formats in Kibana guide (#195880)](#195880) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"kosabogi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T08:48:36Z","message":"Updates file upload formats in Kibana guide (#195880)\n\n### Overview\r\n\r\nThis PR updates the **Upload a file** section in the **Add data** page\r\nto reflect the changes to the supported file formats in the Data\r\nVisualizer.\r\n\r\n### Related issue: \r\n\r\n\r\nhttps://github.com/elastic/search-docs-team/issues/189#issuecomment-2399079270\r\n\r\n### Preview","sha":"94ee8d598fe9fdf388a49e48580c2db58e85df2b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"Updates file upload formats in Kibana guide","number":195880,"url":"https://github.com/elastic/kibana/pull/195880","mergeCommit":{"message":"Updates file upload formats in Kibana guide (#195880)\n\n### Overview\r\n\r\nThis PR updates the **Upload a file** section in the **Add data** page\r\nto reflect the changes to the supported file formats in the Data\r\nVisualizer.\r\n\r\n### Related issue: \r\n\r\n\r\nhttps://github.com/elastic/search-docs-team/issues/189#issuecomment-2399079270\r\n\r\n### Preview","sha":"94ee8d598fe9fdf388a49e48580c2db58e85df2b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195880","number":195880,"mergeCommit":{"message":"Updates file upload formats in Kibana guide (#195880)\n\n### Overview\r\n\r\nThis PR updates the **Upload a file** section in the **Add data** page\r\nto reflect the changes to the supported file formats in the Data\r\nVisualizer.\r\n\r\n### Related issue: \r\n\r\n\r\nhttps://github.com/elastic/search-docs-team/issues/189#issuecomment-2399079270\r\n\r\n### Preview","sha":"94ee8d598fe9fdf388a49e48580c2db58e85df2b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: kosabogi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the Upload a file section in the Add data page to reflect the changes to the supported file formats in the Data Visualizer.
Related issue:
https://github.com/elastic/search-docs-team/issues/189#issuecomment-2399079270
Preview