Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Inventory] Fix top empty space in side navigation when content exceeds window height (#195756) #195878

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ds window height (elastic#195756)

## Summary

Fixes  elastic#195203

This PR addresses an issue in the new Inventory plugin where the side
navigation displayed an unexpected empty space at the top whenever the
page content exceeded the window height.

|Before|After|
|-|-|

|![scroll_fix_before](https://github.com/user-attachments/assets/3eaa4aa5-d42c-4424-9bd4-4225c469c957)|![scroll_fix_after](https://github.com/user-attachments/assets/7a936c05-6c74-463d-b5d6-11e26ff9d191)|

(cherry picked from commit 095113f)
@kibanamachine kibanamachine merged commit a402448 into elastic:8.x Oct 11, 2024
26 of 27 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 237 224 -13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 222.8KB 216.3KB -6.5KB

cc @iblancof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants